[HADOOP-3470] Bad coding style: The member fields in org.apache.hadoop.ipc.metrics.RpcMetrics are public

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Component/s: metrics
• Assignee: Unassigned
• Reporter: Tsz-wo Sze
• Created: 30/May/08 18:38
• Updated: 18/Jul/14 05:25
• Resolved: 18/Jul/14 05:25

Description

In org.apache.hadoop.ipc.metrics.RpcMetrics,

//the following are member fields
  public MetricsTimeVaryingRate rpcQueueTime = new MetricsTimeVaryingRate("RpcQueueTime");
  public MetricsTimeVaryingRate rpcProcessingTime = new MetricsTimeVaryingRate("RpcProcessingTime");

  public Map <String, MetricsTimeVaryingRate> metricsList = Collections.synchronizedMap(new HashMap<String, MetricsTimeVaryingRate>());

Then, the fields are accessed directly in other classes. For example, org.apache.hadoop.ipc.RPC.Server.call(...)

...
	MetricsTimeVaryingRate m = rpcMetrics.metricsList.get(call.getMethodName());

	if (m != null) {
		m.inc(processingTime);
	}
	else {
		rpcMetrics.metricsList.put(call.getMethodName(), new MetricsTimeVaryingRate(call.getMethodName()));
		m = rpcMetrics.metricsList.get(call.getMethodName());
		m.inc(processingTime);
	}

Issue Links

• incorporates: HADOOP-4838 Cleanup Metrics and the MBeans
• is related to: HADOOP-5714 Metric to show number of fs.exists (or number of getFileInfo) calls