Issue Details (XML | Word | Printable)

Key: HADOOP-4838
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Sanjay Radia
Reporter: Sanjay Radia
Votes: 1
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

Cleanup Metrics and the MBeans

Created: 11/Dec/08 06:28 PM   Updated: 23/Apr/09 07:17 PM
Return to search
Component/s: None
Affects Version/s: 0.20.0
Fix Version/s: 0.20.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works 4838-1.patch 2008-12-11 06:47 PM Sanjay Radia 98 kB
Text File Licensed for inclusion in ASF works 4838-2.patch 2008-12-12 05:43 AM Sanjay Radia 101 kB
Text File Licensed for inclusion in ASF works 4838-3.patch 2008-12-15 06:55 PM Sanjay Radia 101 kB
Text File Licensed for inclusion in ASF works 4838-4.patch 2008-12-16 12:01 AM Sanjay Radia 101 kB
Issue Links:
Incorporates
 

Resolution Date: 16/Dec/08 01:02 AM


 Description  « Hide
This patch cleans up the metrics to make it easier to write metrics and the mbeans.
Added a registry to the metrics so that the pushing of metrics can be done automatically.
Also this registry is used to create dynamic mbeans from metrics.
Added the dynamic mbeans base and changed the existing activity beans to use them.
Also cleanup the names of the mbeans.

Hence each time a new metrics is added to an existing set of metrics, one needs to simply do
1) add the metrics to a holder class (such as NameNodeMetrics
2) add code to update the metrics.
The metrics will be pushed as per metrics config and it will also be published via mbeans.
(Previous to this patch also has to add a line of code to push and add new mbean entries).

If one is adding a new category of metrics (ie for which a holder class does not exist) then
1) create metrics holder (see NameNodeMetrics as an example)
2) create mbean (see NameNodeActivityMBean as an example)



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Tsz Wo (Nicholas), SZE made changes - 11/Dec/08 06:39 PM
Field Original Value New Value
Link This issue is part of HADOOP-3470 [ HADOOP-3470 ]
Sanjay Radia made changes - 11/Dec/08 06:47 PM
Attachment 4838-1.patch [ 12395863 ]
Sanjay Radia made changes - 12/Dec/08 05:43 AM
Attachment 4838-2.patch [ 12395907 ]
Sanjay Radia made changes - 12/Dec/08 05:44 AM
Status Open [ 1 ] Patch Available [ 10002 ]
Sanjay Radia made changes - 15/Dec/08 06:55 PM
Attachment 4838-3.patch [ 12396115 ]
Sanjay Radia made changes - 15/Dec/08 07:41 PM
Fix Version/s 0.20.0 [ 12313438 ]
Sanjay Radia made changes - 16/Dec/08 12:01 AM
Attachment 4838-4.patch [ 12396142 ]
Arun C Murthy made changes - 16/Dec/08 01:02 AM
Status Patch Available [ 10002 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Arun C Murthy made changes - 16/Dec/08 01:04 AM
Assignee Sanjay Radia [ sanjay.radia ]
Nigel Daley made changes - 23/Apr/09 07:17 PM
Status Resolved [ 5 ] Closed [ 6 ]