[CASSANDRA-15766] NoSpamLogger arguments building objects on hot paths

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta2, 4.0
• Component/s: Observability/Logging
• Bug Category: Degradation - Performance Bug/Regression
• Severity: Normal
• Complexity: Normal
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 4.0-alpha1

Source Control Link

1266fec349e76b964b522d11460f1df4adadcb48

Test and Documentation Plan

Just passing utests and dtests, assuming reviewed performance improvements are non-controversial. Shouldn't be any impact on documentation.

• Assignee: Caleb Rackliffe
• Reporter: Jon Meredith

Authors

Caleb Rackliffe

Reviewers

Aleksey Yeschenko, Zhao Yang

• Created: 28/Apr/20 13:54
• Updated: 16/Mar/22 14:01
• Resolved: 22/Jul/20 12:52

Description

NoSpamLogger is used in hot logging paths to prevent logs being overrun.  For that to be most effective the arguments to the logger need to be cheap to construct.  During the internode messaging refactor CASSANDRA-15066, performance changes to BufferPool for CASSANDRA-14416
were accidentally reverted in the merge up from 3.11.

Reviewing other uses since, it looks like there are a few places where the arguments require some form of String building.

org.apache.cassandra.net.InboundSink#accept
org.apache.cassandra.net.InboundMessageHandler#processCorruptFrame
org.apache.cassandra.net.InboundMessageHandler.LargeMessage#deserialize
org.apache.cassandra.net.OutboundConnection#onOverloaded
org.apache.cassandra.utils.memory.BufferPool.GlobalPool#allocateMoreChunks

Formatting arguments should either be precomputed, or if expensive they should be computed after the decision on whether to noSpamLog has been made.

Issue Links

• is duplicated by: CASSANDRA-15764 Optimize logging with lazy log parameter evaluation
• is related to: CASSANDRA-15700 Performance regression on internode messaging
• is related to: CASSANDRA-14416 Remove string formatting lines from hot path