[AMBARI-23368] Initialize 'topologyHolder', 'hostLevelParamsHolder', 'recoveryConfigHelper' in HostResourceProvider.

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 3.0.0
• Component/s: ambari-server
• Labels: pull-request-available
• Assignee: Swapan Shridhar
• Reporter: Swapan Shridhar
• Due: 26/Mar/18
• Created: 27/Mar/18 03:56
• Updated: 27/Mar/18 19:21

Description

• After trunk merge into branch-feature-AMBARI-14714

commit 65f010cfce4af4eeffc72a125bf2307f7fbc1e87
Merge: 8e5b0de 0ed3485
Author: Swapan Shridhar <[e-mail]>
Date:   Mon Mar 26 16:32:54 2018 -0700

    Merging Trunk to branch : 'branch-feature-AMBARI-14714'.

• POST hosts started failing with NPE at https://github.com/apache/ambari/blob/branch-feature-AMBARI-14714/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java#L585

Stack Trace:

ambari-server.log

27 Mar 2018 03:03:08,284  WARN [ambari-client-thread-95] HttpChannel:507 - /api/v1/clusters/c1/hosts
java.lang.NullPointerException
        at org.apache.ambari.server.controller.internal.HostResourceProvider.createHosts(HostResourceProvider.java:585)
        at org.apache.ambari.server.controller.internal.HostResourceProvider$1.invoke(HostResourceProvider.java:255)
        at org.apache.ambari.server.controller.internal.HostResourceProvider$1.invoke(HostResourceProvider.java:252)
        at org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:465)
        at org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:288)
        at org.apache.ambari.server.controller.internal.HostResourceProvider.createResourcesAuthorized(HostResourceProvider.java:252)
        at org.apache.ambari.server.controller.internal.AbstractAuthorizedResourceProvider.createResources(AbstractAuthorizedResourceProvider.java:231)

Code Line:

https://github.com/apache/ambari/blob/branch-feature-AMBARI-14714/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java#L585

           for (HostLevelParamsUpdateEvent hostLevelParamsUpdateEvent : hostLevelParamsUpdateEvents) {
      hostLevelParamsHolder.updateData(hostLevelParamsUpdateEvent);
    }

Reason : With perf->trunk->feature branch merge, we have started using hostLevelParamsHolder, which has not been initialized/injected. Similarly for others : 'topologyHolder' and 'recoveryConfigHelper'.

Fix : Added initialization code for them.

CC mradhakrishnan | sduan | jluniya

Issue Links

• links to: GitHub Pull Request #792