Apache OpenOffice (AOO) Bugzilla – Issue 97091
move functions ERF and ERFC to ::rtl::math namespace
Last modified: 2017-05-20 11:41:39 UTC
The functions erf() and erfc() belong to C99, but they are not provided by MSVC Express compilers. Those functions are needed in other calculations for example normsdist() - otherwise they would not be in C99. Unfortunately the functions are currently addin-functions and therefore cannot be used in other places in the code at all. I propose to move the calculations to sal and make them available like it has be done for expm1 and log1p. Doing so, they can be used easily where needed and they can be exchanged by the compiler variants when those are available.
Sounds reasonable. Will add an implementation to rtl::math.
Created attachment 60834 [details] patch part for the folder sal
Created attachment 60835 [details] patch part for the folder scaddins
The patches are based on DEV300_m42.
Created attachment 61104 [details] patch now based on odff06, move erf and erfc from scaddins to sal
Created attachment 61105 [details] patch now based on odff06, move erf and erfc from scaddins to sal
In cws odff06: revision 269982 sal/inc/rtl/math.h sal/inc/rtl/math.hxx sal/rtl/source/math.cxx sal/util/sal.map scaddins/source/analysis/analysishelper.cxx Note: I removed the unnecessary (and mismatching because of different calling convention and throws declaration) forward declaration of rtl_math_erfc() before rtl_math_erf()
Present in CWS build.