Apache OpenOffice (AOO) Bugzilla – Issue 52974
using system hsqldb
Last modified: 2006-06-13 13:21:08 UTC
patch attached to implement --with-system-hsqldb. Except that the scp2 profile item is a bit troublesome to #ifdef, the token is too long to token stringify to base the hsqldb.jar entry off an ifdef properly. Not sure of a better solution
Created attachment 28530 [details] proto patch
Hi, I personally think we should do two additional things here:# - add a flag --with-hsqldb-jar to specify the location/nbame of hsqldb.jar. Some broken distributions don't have it in /usr/share/java - check the version. I guess we should check that the hsqldb we use is >= 1.8.0.0... Regards, Rene
To be attached patch implements the new suggestions.
Created attachment 28551 [details] patch based on cmcs + version check and --with-hsqldb-jar
Created attachment 28552 [details] corrected patch
oops. forgot to conditionalize the perl snippet wrt the jar location. fixed in corrected patch
... and then of course the path has to be changed with a define in scp2....
Created attachment 28555 [details] hopefully last patch...
I should have known it. HSQLDB_JAR is not correctly substituted by I don't have an idea currently how to do that otherwise... Would -DHSQLDB_JAR="file://$(HSQLDB_JAR)" or something like that work? I doubt it, but...
http://www.delorie.com/gnu/docs/gcc/cpp_17.html describes how to stringify a macro, the problem is that the Value line is so long it cannot be stringified, at least I couldn't figure one out.
Created attachment 31735 [details] this should work as a cleaner implementation
Created attachment 31738 [details] *groan* $ORIGIN gets expanded of course, new patch
Created attachment 33684 [details] updated patch
I'll try and look after this if jaxpapi gets integrated, and if ValueList idea gets accepted
accepted for consideration post jaxpapi integration
done in systemjava
reopen for qa
back to fixed
ok
.