Issue 124935 - Line length miscalculated when character spacing is expanded
Summary: Line length miscalculated when character spacing is expanded
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: formatting (show other issues)
Version: 4.1.0
Hardware: Mac Mac OS X, all
: P3 Major (vote)
Target Milestone: 4.1.1
Assignee: hdu@apache.org
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 124985
  Show dependency tree
 
Reported: 2014-05-20 04:12 UTC by office
Modified: 2017-05-20 10:35 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 4.1.1_release_blocker+


Attachments
File created to reproduce the described problem (8.28 KB, application/vnd.oasis.opendocument.text)
2014-05-20 04:12 UTC, office
no flags Details
Screenshot of repro doc in 3.4.1 (no problem) (374.22 KB, image/tiff)
2014-05-20 04:15 UTC, office
no flags Details
Screenshot of repro doc in 4.1.0 (problem occurs) (335.80 KB, image/tiff)
2014-05-20 04:16 UTC, office
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description office 2014-05-20 04:12:12 UTC
Created attachment 83424 [details]
File created to reproduce the described problem

The attached document ("Untitled 1.odt") displays correctly in OO 3.4.1 (see screenshot 1), but in 4.1.0 the second line extends beyond the right margin of the page (screenshot 2). The critical setting is that the character spacing is "expanded." when the spacing is "normal," the problem does not occur.

Note that the problem occurs regardless of the paragraph justification: left, right, center, full. Also, the problem occurs when the document is printed.

This was working as late as 4.0.1. We no longer have access to that version and are forced to work with 3.4.1 until this can be resolved.
Comment 1 office 2014-05-20 04:15:11 UTC
Created attachment 83425 [details]
Screenshot of repro doc in 3.4.1 (no problem)
Comment 2 office 2014-05-20 04:16:45 UTC
Created attachment 83426 [details]
Screenshot of repro doc in 4.1.0 (problem occurs)
Comment 3 SVN Robot 2014-05-20 12:00:51 UTC
"hdu" committed SVN revision 1596218 into trunk:
#i124935# fix expanded/condensed text breaking in the CoreText engine
Comment 4 hdu@apache.org 2014-05-20 12:04:30 UTC
Fixed with the commit above. It extends the CTLayout::GetTextBreak() method to handle the obsolete semantic of per code-unit extra-widths by successively approximating the number of involved code-units.

The concept of an extra-width per code-unit was obsolete at least since apps
supported unicode with its different normalization forms, diacritical marks,
surrogate-pairs, non-printing characters such as ZWJ/ZWNJ/RLM, etc.
Comment 5 hdu@apache.org 2014-05-20 12:07:24 UTC
(In reply to office from comment #0)
> This was working as late as 4.0.1. We no longer have access to that version

Apache OpenOffice releases are archived and available at
https://archive.apache.org/dist/openoffice/
Comment 6 jsc 2014-06-12 13:28:36 UTC
grant showstopper flag for AOO 4.1.1
Comment 7 SVN Robot 2014-06-13 11:01:16 UTC
"hdu" committed SVN revision 1602369 into branches/AOO410:
#i124935# fix expanded/condensed text breaking in the CoreText engine
Comment 8 hdu@apache.org 2014-06-13 11:02:08 UTC
The fix has been merged for the AOO 4.1.1 target.
Comment 9 David Paenson 2014-06-30 12:01:38 UTC
OK. Resolved.

Under AOO 4.1.1 Build 9770 Ubuntu 14.04.

Marked complete line of block text and applied Format -> Character -> Position -> Spacing -> Expanded 2pt. Line ends correctly at right margin and words get carried on to next line correctly.
Comment 10 Ariel Constenla-Haile 2014-06-30 12:25:11 UTC
(In reply to David Paenson from comment #9)
> OK. Resolved.
> 
> Under AOO 4.1.1 Build 9770 Ubuntu 14.04.

This one is also a regression on MacOSX, it should be verified on that platform.
Comment 11 jsc 2014-06-30 14:37:09 UTC
it's MacOS of course but it's always useful to cross check on the other platforms as well
Comment 12 Ariel Constenla-Haile 2014-06-30 20:45:50 UTC
(In reply to jsc from comment #11)
> it's MacOS of course but it's always useful to cross check on the other
> platforms as well

While this applies in general, how could a change in vcl/aqua/source/gdi/ctlayout.cxx impact other platforms?
IMO we shouldn't waste QA contributor's time when we are in the know.
Comment 13 fanyuzhen 2014-07-18 07:46:39 UTC
It's verified fixed in build AOO411m2(Build:9771)  -  Rev. 1608452
2014-07-07 15:29:02 (Mon, 07 Jul 2014)