Issue 122707 - [sidebar] Show frame around sidebar toolbars
[sidebar] Show frame around sidebar toolbars
Status: VERIFIED FIXED
Product: General
Classification: Code
Component: ui
4.0.0-dev
All All
: P3 normal (vote)
: 4.0.0
Assigned To: AOO issues mailing list
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-09 07:57 UTC by Andre
Modified: 2013-07-15 11:11 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation on: ---
Developer Difficulty: ---
jsc: 4.0.0_release_blocker+


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Andre 2013-07-09 07:57:22 UTC
As small but important enhancement of the visibility of toolbars in sidebar panels, show a one pixel frame around them.  Especially on the top side of the toolbars, where their background gradient has the same color as the panel background, toolbars are hard to distinguish from the background.
Comment 1 Andre 2013-07-09 09:17:35 UTC
Requesting show stopper flag to make a new feature as good as possible.
Fix exists. Should be harmless because it just changes some colors and spacings.
Comment 2 jsc 2013-07-09 09:24:47 UTC
grant showstopper flag

proposed on dev list last week, no objections -> seems to be common consensus
Comment 3 SVN Robot 2013-07-09 09:45:08 UTC
"af" committed SVN revision 1501169 into trunk:
122707: Show a frame around toolbars in sidebar panels.
Comment 4 Andre 2013-07-09 09:48:24 UTC
Changed the color values in sfx2/source/sidebar/Theme.cxx for the toolbox frame.  They are now based on the background color (as provided by StyleSettings.GetDialogColor()) instead of being fixed color values.

I had to tweek one distance between controls in the text property panel.  The controls where to close to each other in the 'de' version and the now visible frame made that visible.
Comment 5 jsc 2013-07-15 11:11:17 UTC
verified on RC build on MacOS and Windows