Issue 122401 - New (.uno:AddDirect) button of standard toolbar not working well on Basic IDE
New (.uno:AddDirect) button of standard toolbar not working well on Basic IDE
Status: RESOLVED FIXED
Product: General
Classification: Code
Component: ui
4.0.0-dev
All All
: P3 normal (vote)
: 4.0.0
Assigned To: Ariel Constenla-Haile
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-28 20:10 UTC by hanya
Modified: 2013-07-21 10:10 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation on: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description hanya 2013-05-28 20:10:08 UTC
Nothing happen when I click on the New button of standard toolbar on Basic IDE.
- Choosing an entry from the dropdown menu is working.
- To click on the New button, not working.
On other document types, it seems ok.

On Xubuntu 12.04 64bit in VMware Player, 
Apache_OpenOffice_4.0.0_Linux_x86-64_install-deb_en-US.tar.gz_2013-05-28_04:09:49_1486733.tar.gz
AOO400m2(Build:9701)  -  Rev. 1486702
2013-05-28_04:09:49 - Rev. 1486733
And also Xubuntu 32bit, Rev. 1486438 built myself.
Comment 1 Ariel Constenla-Haile 2013-05-28 20:34:45 UTC
I've got a fix for that forgot to commit (note to myself: cherry-picking from a git clone seems error prone when no using stgit, nor git-svn).

IIRC something happens, the private URL from basic is dispatched, what of course does nothing.
Comment 2 SVN Robot 2013-05-28 22:09:28 UTC
"arielch" committed SVN 0 into trunk:
i122401 - framework::NewToolbarController needs early initialization of its P...
Comment 3 Ariel Constenla-Haile 2013-05-28 22:23:18 UTC
The main reason was that the algorithms relay on the PopupMenu filled at initialization. The default behaviour of framework::PopupMenuToolbarController is the later initialization of the PopupMenuController, only when the drop-down button is pressed. If early initialization is needed, the derived class has to override initialize(). 

@hanya please check with 0

There shouldn't be any new bugs, as the code is mainly copy&paste from the old implementation.

Looking at my notes back then, the old implementation had issues with the Writer based URL containing slots in the query part, as in

private:factory/swriter?slot=21051
private:factory/swriter?slot=21052
private:factory/swriter?slot=21053

it dispatched the URL without the query part. Feel free to open a new bug for this.