Issue 116037 - Don't toggle the calc formula bar when activating and deactivating a chart
Summary: Don't toggle the calc formula bar when activating and deactivating a chart
Status: CONFIRMED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-10 10:26 UTC by thomas.benisch
Modified: 2013-02-24 21:20 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
first attempt with remaining problem (8.16 KB, patch)
2011-03-03 15:59 UTC, thomas.benisch 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description thomas.benisch 2010-12-10 10:26:07 UTC 
When activating a chart in a spreadsheet document, the Calc formula
bar is hidden. When deactivating the chart, the formula bar is shown
again. With the default toolbar configuration the activating and
deactivating of a chart in a spreadsheet document changes the
position of the chart. This behaviour is rather confusing.

A better approach is to show the formula bar also for an activated
chart, but in a disabled state.
Comment 1 thomas.benisch 2010-12-10 10:27:03 UTC 
accepted
Comment 2 thomas.benisch 2010-12-10 11:05:36 UTC 
fixed in CWS chart51
Comment 3 thomas.benisch 2010-12-10 11:20:33 UTC 
This issue was fixed together with cd@openoffice.org, who contributed the
sfx2 part. The fix relies on the implementation detail, that chart is not
a sfx based application and therefore the SfxWorkWindow is not exchanged
and keeps all its child windows. The calc formula bar is one of those
child windows and is kept visible by setting the 
SFX_CHILDWIN_NEVERHIDEACTIVEOLE flag. For sfx based applications, e.g.
a writer, which was inserted as OLE object, this approach is not
working. In this case the SfxWorkWindow is exchanged and the
calc formula bar is not available as child window anymore.

As a mid-term approach the idea is to implement the calc formula bar
as a standard toolbar, so that the framework can keep control.
Comment 4 thomas.benisch 2011-02-17 18:15:28 UTC 
TBE->KLA: Please verify in CWS chart51.
Comment 5 thomas.benisch 2011-03-03 15:59:12 UTC 
Created attachment 75983 [details]
first attempt with remaining problem

This is a first attempt of fixing this issue.
Unfortunately there remains the problem, that when activating
the chart, a docked navigator doesn't toggle, but an empty
sfx child window is still visible.