|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | replace lcc based preprocessor with ucpp | ||
|---|---|---|---|
| Product: | App Dev | Reporter: | jsc |
| Component: | sdk | Assignee: | jsc |
| Status: | CLOSED OBSOLETE | QA Contact: | |
| Severity: | Critical | ||
| Priority: | P5 (lowest) | CC: | issues, pfg |
| Version: | 3.3.0 or older (OOo) | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | All | ||
| Issue Type: | DEFECT | Latest Confirmation in: | --- |
| Developer Difficulty: | --- | ||
| Issue Depends on: | |||
| Issue Blocks: | 118595 | ||
|
Description
jsc
2011-11-02 11:02:12 UTC
Hi, Some comments concerning the new idlc preprocessor module (ucpp): - The ucpp directory has a makefile and a patch under the LGPL3. These are new files so they should not carry the old license. Furthermore, patches should be under the same license of the upstream code. - it appears this uses dmake which will be deprecated, for new modules we should use gbuild. - it should be possible to use a preinstalled ucpp instead of rebuilding it. 1. you are right the license should be changed, i forgot this 2. the patch will be under AL because it creates only a makefile and nothing else. The original source are unpatched. 3. dmake is used because the patch mechanism is adapted to gbuild. This will change when it is available. Maybe i have missed it. 4. ucpp is very small and i simply build it every time instead of extending the configure script etc. Go ahead to change it if you like. (In reply to comment #2) > 1. you are right the license should be changed, i forgot this Thanks. > 2. the patch will be under AL because it creates only a makefile and nothing > else. The original source are unpatched. Yes, I noticed. The uccp makefile is pretty simple though and I noticed for other modules (hunspell) we do use the available makefile. I don't really "get" this build system so just take my suggestions with a grain of salt. > 3. dmake is used because the patch mechanism is adapted to gbuild. This will > change when it is available. Maybe i have missed it. I am missing it too ;-). > 4. ucpp is very small and i simply build it every time instead of extending the > configure script etc. Go ahead to change it if you like. Yes, maybe later. Thanks! this is obsolete closed |