Issue 118568 - replace lcc based preprocessor with ucpp
Summary: replace lcc based preprocessor with ucpp
Status: CLOSED OBSOLETE
Alias: None
Product: App Dev
Classification: Unclassified
Component: sdk (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: PC All
: P5 (lowest) Critical
Target Milestone: ---
Assignee: jsc
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 118595
  Show dependency tree
 
Reported: 2011-11-02 11:02 UTC by jsc
Modified: 2013-06-04 09:19 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description jsc 2011-11-02 11:02:12 UTC
Replace the license incompatible preprocessor code based on lcc with the ucpp preprocessor that is under BSD license

See http://code.google.com/p/ucpp
Comment 1 Pedro Giffuni 2011-12-08 00:57:47 UTC
Hi,
Some comments concerning the new idlc preprocessor module (ucpp):
- The ucpp directory has a makefile and a patch under the LGPL3. These are new files so they should not carry the old license. Furthermore, patches should be under the same license of the upstream code.
- it appears this uses dmake which will be deprecated, for new modules we should use gbuild.
- it should be possible to use a preinstalled ucpp instead of rebuilding it.
Comment 2 jsc 2011-12-08 08:17:47 UTC
1. you are right the license should be changed, i forgot this
2. the patch will be under AL because it creates only a makefile and nothing else. The original source are unpatched.
3. dmake is used because the patch mechanism is adapted to gbuild. This will change when it is available. Maybe i have missed it.
4. ucpp is very small and i simply build it every time instead of extending the configure script etc. Go ahead to change it if you like.
Comment 3 Pedro Giffuni 2011-12-08 16:10:07 UTC
(In reply to comment #2)
> 1. you are right the license should be changed, i forgot this

Thanks.

> 2. the patch will be under AL because it creates only a makefile and nothing
> else. The original source are unpatched.

Yes, I noticed. The uccp makefile is pretty simple though and I noticed for other modules (hunspell) we do use the available makefile. I don't really "get" this build system so just take my suggestions with a grain of salt.

> 3. dmake is used because the patch mechanism is adapted to gbuild. This will
> change when it is available. Maybe i have missed it.

I am missing it too ;-).

> 4. ucpp is very small and i simply build it every time instead of extending the
> configure script etc. Go ahead to change it if you like.

Yes, maybe later. Thanks!
Comment 4 jsc 2013-06-04 09:18:52 UTC
this is obsolete
Comment 5 jsc 2013-06-04 09:19:07 UTC
closed