Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4764

Rust frontend emits deprecated clippy suppression attributes

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.14.0
    • Rust - Compiler
    • None
    • Ubuntu Cosmic x64

      Thrift from master

    Description

      Currently, following lines are inserted:

      #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))]
      

      But this syntax is deprecated now.

      Following should be used instead:

      #![allow(clippy::too_many_arguments, clippy::type_complexity)]
      

      Note: I fixed this issue in my fork, but I'm not sure if it will be easier for developers to merge my PR than apply changes themselves. Also, I'm student and my Git skills are not very good)

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            allengeorge Allen George
            MikailBag Mikail Bagishov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h
                1h

                Slack

                  Issue deployment