[THRIFT-4764] Rust frontend emits deprecated clippy suppression attributes

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: Rust - Compiler

Environment

Ubuntu Cosmic x64

Thrift from master

• Assignee: Allen George
• Reporter: Mikail Bagishov
• Created: 29/Jan/19 18:18
• Updated: 11/Feb/21 22:26
• Resolved: 19/Nov/20 03:45

Description

Currently, following lines are inserted:

#![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))]

But this syntax is deprecated now.

Following should be used instead:

#![allow(clippy::too_many_arguments, clippy::type_complexity)]

Note: I fixed this issue in my fork, but I'm not sure if it will be easier for developers to merge my PR than apply changes themselves. Also, I'm student and my Git skills are not very good)

Issue Links

• is related to: THRIFT-5307 Rust generated code should compile cleanly with clippy
• links to: GitHub Pull Request #1726
• links to: GitHub Pull Request #2076