Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-1163

GetHTTP throws an NPE if a context service is used with only a truststore and no keystore

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.3.0
    • 0.4.0
    • Extensions
    • None

    Description

      Consider a one-way SSL connection to an HTTPS endpoint. We might want to specify a truststore to talk with that endpoint but not a keystore.

      The problem stems from the following method:

          private SSLContext createSSLContext(final SSLContextService service)
                  throws KeyStoreException, IOException, NoSuchAlgorithmException, CertificateException, KeyManagementException, UnrecoverableKeyException {
              final KeyStore truststore = KeyStore.getInstance(service.getTrustStoreType());
              try (final InputStream in = new FileInputStream(new File(service.getTrustStoreFile()))) {
                  truststore.load(in, service.getTrustStorePassword().toCharArray());
              }
      
              final KeyStore keystore = KeyStore.getInstance(service.getKeyStoreType());
              try (final InputStream in = new FileInputStream(new File(service.getKeyStoreFile()))) {
                  keystore.load(in, service.getKeyStorePassword().toCharArray());
              }
      
              final SSLContext sslContext = SSLContexts.custom().loadTrustMaterial(truststore, new TrustSelfSignedStrategy()).loadKeyMaterial(keystore, service.getKeyStorePassword().toCharArray()).build();
      
              return sslContext;
          }
      

      In this case there are no keystore properties causing this process to fail.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            aldrin Aldrin Piri
            aldrin Aldrin Piri
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment