[NIFI-1163] GetHTTP throws an NPE if a context service is used with only a truststore and no keystore

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.3.0
• Fix Version/s: 0.4.0
• Component/s: Extensions
• Assignee: Aldrin Piri
• Reporter: Aldrin Piri
• Created: 13/Nov/15 17:33
• Updated: 14/Nov/15 23:51
• Resolved: 14/Nov/15 23:51

Description

Consider a one-way SSL connection to an HTTPS endpoint. We might want to specify a truststore to talk with that endpoint but not a keystore.

The problem stems from the following method:

    private SSLContext createSSLContext(final SSLContextService service)
            throws KeyStoreException, IOException, NoSuchAlgorithmException, CertificateException, KeyManagementException, UnrecoverableKeyException {
        final KeyStore truststore = KeyStore.getInstance(service.getTrustStoreType());
        try (final InputStream in = new FileInputStream(new File(service.getTrustStoreFile()))) {
            truststore.load(in, service.getTrustStorePassword().toCharArray());
        }

        final KeyStore keystore = KeyStore.getInstance(service.getKeyStoreType());
        try (final InputStream in = new FileInputStream(new File(service.getKeyStoreFile()))) {
            keystore.load(in, service.getKeyStorePassword().toCharArray());
        }

        final SSLContext sslContext = SSLContexts.custom().loadTrustMaterial(truststore, new TrustSelfSignedStrategy()).loadKeyMaterial(keystore, service.getKeyStorePassword().toCharArray()).build();

        return sslContext;
    }

In this case there are no keystore properties causing this process to fail.

Issue Links

• is related to: NIFI-700 GetHTTP, ListenHTTP, and PostHTTP should be migrated to use SSLContextService fully