Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16971

The passed durability of Append/Increment isn't used in wal sync

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0
    • None
    • None
    • Reviewed

    Description

      We should pass the “effectiveDurability” to the doWALAppend() metohd.

      HRegion.java
      private Result doDelta(...) {
              Durability effectiveDurability = getEffectiveDurability(mutation.getDurability());
              Map<Store, List<Cell>> forMemStore =
                  new HashMap<Store, List<Cell>>(mutation.getFamilyCellMap().size());
              // Reckon Cells to apply to WAL --  in returned walEdit -- and what to add to memstore and
              // what to return back to the client (in 'forMemStore' and 'results' respectively).
              WALEdit walEdit = reckonDeltas(op, mutation, effectiveDurability, forMemStore, results);
              // Actually write to WAL now if a walEdit to apply.
              if (walEdit != null && !walEdit.isEmpty()) {
                writeEntry = doWALAppend(walEdit, durability, nonceGroup, nonce);
              } else {
      }
      

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            chia7712 Chia-Ping Tsai Assign to me
            chia7712 Chia-Ping Tsai
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment