[HBASE-16971] The passed durability of Append/Increment isn't used in wal sync

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Chia-Ping Tsai
• Reporter: Chia-Ping Tsai
• Created: 31/Oct/16 03:08
• Updated: 31/Oct/16 20:31
• Resolved: 31/Oct/16 16:51

Description

We should pass the “effectiveDurability” to the doWALAppend() metohd.

HRegion.java

private Result doDelta(...) {
        Durability effectiveDurability = getEffectiveDurability(mutation.getDurability());
        Map<Store, List<Cell>> forMemStore =
            new HashMap<Store, List<Cell>>(mutation.getFamilyCellMap().size());
        // Reckon Cells to apply to WAL --  in returned walEdit -- and what to add to memstore and
        // what to return back to the client (in 'forMemStore' and 'results' respectively).
        WALEdit walEdit = reckonDeltas(op, mutation, effectiveDurability, forMemStore, results);
        // Actually write to WAL now if a walEdit to apply.
        if (walEdit != null && !walEdit.isEmpty()) {
          writeEntry = doWALAppend(walEdit, durability, nonceGroup, nonce);
        } else {
}

Issue Links

• is related to: HBASE-15158 Change order in which we do write pipeline operations; do all under row locks!