Uploaded image for project: 'Commons Crypto'
  1. Commons Crypto
  2. CRYPTO-72

CryptoCipherFactory.getInstance does unnecessary class instantiation

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      The CryptoCipherFactory.getInstance method calls getCipherClasses which splits the string containing the class name(s) and then creates an instance of each (if possible) using ReflectionUtils.getClassByName.

      However the getInstance method stops processing on the first successful class, so any subsequent entries are not used.

      This is wasteful; the call to ReflectionUtils.getClassByName should only be done if it is going to be used.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            dapengsun Dapeng Sun
            sebb Sebb
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment