[CRYPTO-72] CryptoCipherFactory.getInstance does unnecessary class instantiation

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Assignee: Dapeng Sun
• Reporter: Sebb
• Created: 15/Jun/16 08:59
• Updated: 21/Jun/16 03:04
• Resolved: 21/Jun/16 03:04

Description

The CryptoCipherFactory.getInstance method calls getCipherClasses which splits the string containing the class name(s) and then creates an instance of each (if possible) using ReflectionUtils.getClassByName.

However the getInstance method stops processing on the first successful class, so any subsequent entries are not used.

This is wasteful; the call to ReflectionUtils.getClassByName should only be done if it is going to be used.