Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.2, 3.3.3
    • Fix Version/s: 3.4.0
    • Component/s: leaderElection
    • Labels:
      None
    • Environment:

      Linux box, Eclipse IDE,

      Description

      In the file org.apache.zookeeper.server.quorum.FastLeaderElection.java for methods like totalOrderPredicate and termPredicate, which return boolean, the code is as below :

      if (condition)
      return true;
      else
      return false;

      I feel, it would be better if the condition itself is returned.
      i.e., return condition.

      The same thing holds good else where if applicable.

        Attachments

          Activity

            People

            • Assignee:
              mis MIS
              Reporter:
              mis MIS
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0.5h
                0.5h
                Remaining:
                Remaining Estimate - 0.5h
                0.5h
                Logged:
                Time Spent - Not Specified
                Not Specified