Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.2, 3.3.3
    • Fix Version/s: 3.4.0
    • Component/s: leaderElection
    • Labels:
      None
    • Environment:

      Linux box, Eclipse IDE,

      Description

      In the file org.apache.zookeeper.server.quorum.FastLeaderElection.java for methods like totalOrderPredicate and termPredicate, which return boolean, the code is as below :

      if (condition)
      return true;
      else
      return false;

      I feel, it would be better if the condition itself is returned.
      i.e., return condition.

      The same thing holds good else where if applicable.

        Activity

        Mahadev konar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Flavio Junqueira made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Patrick Hunt made changes -
        Assignee MIS [ mis ]
        Benjamin Reed made changes -
        Fix Version/s 3.4.0 [ 12314469 ]
        Fix Version/s 3.3.3 [ 12315482 ]
        MIS made changes -
        Attachment ZOOKEEPER-993-patch.txt [ 12471309 ]
        MIS made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        MIS created issue -

          People

          • Assignee:
            MIS
            Reporter:
            MIS
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.5h
              0.5h
              Remaining:
              Remaining Estimate - 0.5h
              0.5h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development