[ZOOKEEPER-993] Code improvements

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3.2, 3.3.3
• Fix Version/s: 3.4.0
• Component/s: leaderElection

Environment

Linux box, Eclipse IDE,

• Assignee: MIS
• Reporter: MIS
• Created: 17/Feb/11 21:31
• Updated: 23/Nov/11 23:22
• Resolved: 16/Mar/11 18:59

Description

In the file org.apache.zookeeper.server.quorum.FastLeaderElection.java for methods like totalOrderPredicate and termPredicate, which return boolean, the code is as below :

if (condition)
return true;
else
return false;

I feel, it would be better if the condition itself is returned.
i.e., return condition.

The same thing holds good else where if applicable.