Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-973

bind() could fail on Leader because it does not setReuseAddress on its ServerSocket

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.3.2
    • Fix Version/s: 3.4.3, 3.3.5, 3.5.0
    • Component/s: server
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      setReuseAddress(true) should be used below.

      Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
      this.self = self;
      try

      { ss = new ServerSocket(self.getQuorumAddress().getPort()); }

      catch (BindException e)

      { LOG.error("Couldn't bind to port " + self.getQuorumAddress().getPort(), e); throw e; }

      this.zk=zk;
      }

      1. ZOOKEEPER-973.patch
        1 kB
        Harsh J
      2. ZOOKEEPER-973.patch
        1 kB
        Harsh J

        Activity

        Hide
        mahadev Mahadev konar added a comment -

        not a blocker. Moving it out of 3.4 release.

        Show
        mahadev Mahadev konar added a comment - not a blocker. Moving it out of 3.4 release.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12509538/ZOOKEEPER-973.patch
        against trunk revision 1227000.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/878//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/878//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/878//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12509538/ZOOKEEPER-973.patch against trunk revision 1227000. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/878//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/878//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/878//console This message is automatically generated.
        Hide
        phunt Patrick Hunt added a comment -

        Harsh, the comment is pretty useless/redundant. Can you remove it from the patch? (otw looks ok). Thanks.

        Show
        phunt Patrick Hunt added a comment - Harsh, the comment is pretty useless/redundant. Can you remove it from the patch? (otw looks ok). Thanks.
        Hide
        qwertymaniac Harsh J added a comment -

        Ah yes, sorry about that.

        Show
        qwertymaniac Harsh J added a comment - Ah yes, sorry about that.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12509657/ZOOKEEPER-973.patch
        against trunk revision 1227927.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/883//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/883//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/883//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12509657/ZOOKEEPER-973.patch against trunk revision 1227927. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/883//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/883//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/883//console This message is automatically generated.
        Hide
        qwertymaniac Harsh J added a comment -

        Hey devs, are there any further comments you'd like me to address on this patch? Do let me know.

        Show
        qwertymaniac Harsh J added a comment - Hey devs, are there any further comments you'd like me to address on this patch? Do let me know.
        Hide
        breed Benjamin Reed added a comment -

        +1 looks good

        Show
        breed Benjamin Reed added a comment - +1 looks good
        Hide
        phunt Patrick Hunt added a comment -

        Thanks Harsh!

        Show
        phunt Patrick Hunt added a comment - Thanks Harsh!
        Hide
        hudson Hudson added a comment -

        Integrated in ZooKeeper-trunk #1438 (See https://builds.apache.org/job/ZooKeeper-trunk/1438/)
        ZOOKEEPER-973. bind() could fail on Leader because it does not setReuseAddress on its ServerSocket (Harsh J via phunt)

        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234974
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
        Show
        hudson Hudson added a comment - Integrated in ZooKeeper-trunk #1438 (See https://builds.apache.org/job/ZooKeeper-trunk/1438/ ) ZOOKEEPER-973 . bind() could fail on Leader because it does not setReuseAddress on its ServerSocket (Harsh J via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234974 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java

          People

          • Assignee:
            qwertymaniac Harsh J
            Reporter:
            vishalmlst Vishal Kher
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development