ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-958

Flag to turn off autoconsume in hedwig c++ client

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.0
    • Fix Version/s: 3.4.0
    • Component/s: contrib-hedwig
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the hedwig cpp client will automatically send a consume message to the server when the calling client indicated that it has received the message. If the client wants to queue the messages and not acknowledge them to the server immediately, they need to block, which means interfering with any other running callbacks.

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12466301/ZOOKEEPER-958.diff
        against trunk revision 1049401.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/68//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/68//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/68//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12466301/ZOOKEEPER-958.diff against trunk revision 1049401. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/68//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/68//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/68//console This message is automatically generated.
        Hide
        Erwin Tam added a comment -

        +1 Changes reviewed and it looks good to me. Thanks Ivan!

        Show
        Erwin Tam added a comment - +1 Changes reviewed and it looks good to me. Thanks Ivan!
        Hide
        Mahadev konar added a comment -

        Marking it for only 3.4 since hedwig isnt there in 3.3 branch.

        Show
        Mahadev konar added a comment - Marking it for only 3.4 since hedwig isnt there in 3.3 branch.
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks Ivan.

        Show
        Mahadev konar added a comment - I just committed this. thanks Ivan.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1045 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1045/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1045 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1045/ )

          People

          • Assignee:
            Ivan Kelly
            Reporter:
            Ivan Kelly
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development