ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-937

test -e not available on solaris /bin/sh

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.0, 3.3.1, 3.3.2
    • Fix Version/s: 3.4.0
    • Component/s: scripts
    • Labels:
      None
    • Environment:

      SunOS xxx 5.10 Generic_142901-13 i86pc i386 i86pc Solaris

    • Hadoop Flags:
      Reviewed

      Description

      test -e FILENAME is not support on /bin/sh in solaris. This is used in bin/zkEnv.sh. We can substitute test -f FILENAME. Attaching a patch.

      1. zk_solaris_zkEnv.patch
        0.3 kB
        Erik Hetzner
      2. zk_solaris_zkEnv.patch
        0.3 kB
        Erik Hetzner

        Activity

        Hide
        Mahadev konar added a comment -

        +1 the patch looks good. marking it PA.

        Show
        Mahadev konar added a comment - +1 the patch looks good. marking it PA.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12460061/zk_solaris_zkEnv.patch
        against trunk revision 1036967.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/40//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12460061/zk_solaris_zkEnv.patch against trunk revision 1036967. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/40//console This message is automatically generated.
        Hide
        Erik Hetzner added a comment -

        patch with proper path.

        Show
        Erik Hetzner added a comment - patch with proper path.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12460076/zk_solaris_zkEnv.patch
        against trunk revision 1036967.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/41//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/41//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/41//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12460076/zk_solaris_zkEnv.patch against trunk revision 1036967. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/41//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/41//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/41//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks Erik.

        Show
        Mahadev konar added a comment - I just committed this. thanks Erik.
        Hide
        Erik Hetzner added a comment -

        Thank you, Mahadev.

        Show
        Erik Hetzner added a comment - Thank you, Mahadev.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1031 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1031/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1031 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1031/ )

          People

          • Assignee:
            Erik Hetzner
            Reporter:
            Erik Hetzner
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development