ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-861

Missing the test SSL certificate used for running junit tests.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: contrib-hedwig
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The Hedwig code checked into Apache is missing a test SSL certificate file used for running the server junit tests. We need this file otherwise the tests that use this (e.g. TestHedwigHub) will fail.

      1. server.p12
        4 kB
        Erwin Tam
      2. ZOOKEEPER-861.patch
        0.4 kB
        Erwin Tam

        Activity

        Hide
        Erwin Tam added a comment -

        Uploading the binary SSL certificate file used for doing junit tests.

        Show
        Erwin Tam added a comment - Uploading the binary SSL certificate file used for doing junit tests.
        Hide
        Michi Mutsuzaki added a comment -
        • I copied server.p12 in src/contrib/hedwig/server/src/main/resources/, and that fixed all the unit test failures.
        • ZOOKEEPER-861.patch doesn't apply. What is this patch supposed to do?

        --Michi

        Show
        Michi Mutsuzaki added a comment - I copied server.p12 in src/contrib/hedwig/server/src/main/resources/, and that fixed all the unit test failures. ZOOKEEPER-861 .patch doesn't apply. What is this patch supposed to do? --Michi
        Hide
        Erwin Tam added a comment -

        The patch won't really apply since it is just showing where the binary file server.p12 should be placed. I don't think there's a way for patches to work when adding new binary files to the source.

        Show
        Erwin Tam added a comment - The patch won't really apply since it is just showing where the binary file server.p12 should be placed. I don't think there's a way for patches to work when adding new binary files to the source.
        Hide
        Patrick Hunt added a comment -

        That's correct, patches only work with non-binaries I'm afraid. The reviewer will need to verify manually as part of the review process.

        Show
        Patrick Hunt added a comment - That's correct, patches only work with non-binaries I'm afraid. The reviewer will need to verify manually as part of the review process.
        Hide
        Michi Mutsuzaki added a comment -

        +1. This fixed all the unit test failures.

        --Michi

        Show
        Michi Mutsuzaki added a comment - +1. This fixed all the unit test failures. --Michi
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks erwin!

        Show
        Mahadev konar added a comment - I just committed this. thanks erwin!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #936 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #936 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/ )

          People

          • Assignee:
            Erwin Tam
            Reporter:
            Erwin Tam
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development