Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5.0
    • Component/s: None
    • Labels:
      None

      Description

      Implement read-only mode functionality (in accordance with http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode) in C client library

      1. ZOOKEEPER-827.patch
        63 kB
        Raul Gutierrez Segales
      2. ZOOKEEPER-827.patch
        63 kB
        Raul Gutierrez Segales
      3. ZOOKEEPER-827.patch
        48 kB
        Raul Gutierrez Segales
      4. ZOOKEEPER-827.patch
        45 kB
        Raul Gutierrez Segales
      5. ZOOKEEPER-827.patch
        37 kB
        Raul Gutierrez Segales
      6. ZOOKEEPER-827.patch
        46 kB
        Sergey Doroshenko
      7. ZOOKEEPER-827.patch
        45 kB
        Sergey Doroshenko
      8. ZOOKEEPER-827.patch
        42 kB
        Sergey Doroshenko
      9. ZOOKEEPER-827.patch
        35 kB
        Sergey Doroshenko
      10. ZOOKEEPER-827.patch
        32 kB
        Sergey Doroshenko

        Activity

        Hide
        Sergey Doroshenko added a comment -

        Workable version of r/o functionality.

        To get r/o-enabled zhandle use zookeeper_init_ro function; zookeeper_init simply delegates to it. Client seeks for r/w server if in r/o state. Default watcher receives appropriate notifications.

        Things to add is handling of "fake" sessions (check ZOOKEEPER-784 and wiki page for details), and tests. For now I do have tests but they are tied to my environment; I also tested added functionality with cli_mt command-line client

        Show
        Sergey Doroshenko added a comment - Workable version of r/o functionality. To get r/o-enabled zhandle use zookeeper_init_ro function; zookeeper_init simply delegates to it. Client seeks for r/w server if in r/o state. Default watcher receives appropriate notifications. Things to add is handling of "fake" sessions (check ZOOKEEPER-784 and wiki page for details), and tests. For now I do have tests but they are tied to my environment; I also tested added functionality with cli_mt command-line client
        Hide
        Sergey Doroshenko added a comment -

        sessions handling added

        Show
        Sergey Doroshenko added a comment - sessions handling added
        Hide
        Sergey Doroshenko added a comment -
        • test added
        • made client backwards compatible with old server

        Overall, that's it. Fully workable r/o mode. Of course, to test it you also need to apply ZOOKEEPER-784

        Show
        Sergey Doroshenko added a comment - test added made client backwards compatible with old server Overall, that's it. Fully workable r/o mode. Of course, to test it you also need to apply ZOOKEEPER-784
        Hide
        Sergey Doroshenko added a comment -

        cancelling patch since test won't pass till server-side changes is integrated to the trunk

        Show
        Sergey Doroshenko added a comment - cancelling patch since test won't pass till server-side changes is integrated to the trunk
        Hide
        Sergey Doroshenko added a comment -

        improved documentation

        Show
        Sergey Doroshenko added a comment - improved documentation
        Hide
        Flavio Junqueira added a comment -

        I was wondering what the status of this patch is. Should it be patch available or there are still things missing?

        Show
        Flavio Junqueira added a comment - I was wondering what the status of this patch is. Should it be patch available or there are still things missing?
        Hide
        Sergey Doroshenko added a comment -

        This is fully workable solution that depends on ZOOKEEPER-784 only

        Show
        Sergey Doroshenko added a comment - This is fully workable solution that depends on ZOOKEEPER-784 only
        Hide
        Flavio Junqueira added a comment -

        Sergey, I'm asking because it is currently not marked as "Patch available". Should it be patch available? From your answer, it sounds like a "yes", but it would be good if you could confirm.

        Show
        Flavio Junqueira added a comment - Sergey, I'm asking because it is currently not marked as "Patch available". Should it be patch available? From your answer, it sounds like a "yes", but it would be good if you could confirm.
        Hide
        Sergey Doroshenko added a comment -

        Since ZOOKEEPER-784 is not in trunk, Hudson will reject this patch. But if you apply 784's patch, this one becomes "patch available"

        Show
        Sergey Doroshenko added a comment - Since ZOOKEEPER-784 is not in trunk, Hudson will reject this patch. But if you apply 784's patch, this one becomes "patch available"
        Hide
        Flavio Junqueira added a comment -

        Got it, thanks for the clarification, Sergey.

        Show
        Flavio Junqueira added a comment - Got it, thanks for the clarification, Sergey.
        Hide
        Sergey Doroshenko added a comment -

        The patch against current trunk's state. As before, depends on ZOOKEEPER-784.

        Show
        Sergey Doroshenko added a comment - The patch against current trunk's state. As before, depends on ZOOKEEPER-784 .
        Hide
        Vishal Kathuria added a comment -

        Committers - it would be great if we could commit this patch.

        Show
        Vishal Kathuria added a comment - Committers - it would be great if we could commit this patch.
        Hide
        Thawan Kooburat added a comment -

        #define READONLY_STATE_DEF 4
        This is inconsistent with server-side definition (5)

        Show
        Thawan Kooburat added a comment - #define READONLY_STATE_DEF 4 This is inconsistent with server-side definition (5)
        Hide
        Raul Gutierrez Segales added a comment -

        I've rebased the available patch on top of master. So far I only made it compile (for Linux, it won't compile for Win32). I'll make the tests pass and complete this during this week (hopefully).

        I'd really like to include this for 3.5.0 because testing ZOOKEEPR-1607 properly depends on this (and, more generally, for any further development/enhancement of read-only support we might as well have this supported in C...).

        Early reviews welcomed, but be warned this is WIP!

        cc: Flavio Junqueira, Michi Mutsuzaki, Rakesh R, Patrick Hunt, Thawan Kooburat

        Show
        Raul Gutierrez Segales added a comment - I've rebased the available patch on top of master. So far I only made it compile (for Linux, it won't compile for Win32). I'll make the tests pass and complete this during this week (hopefully). I'd really like to include this for 3.5.0 because testing ZOOKEEPR-1607 properly depends on this (and, more generally, for any further development/enhancement of read-only support we might as well have this supported in C...). Early reviews welcomed, but be warned this is WIP! cc: Flavio Junqueira , Michi Mutsuzaki , Rakesh R , Patrick Hunt , Thawan Kooburat
        Hide
        Michi Mutsuzaki added a comment -

        Hi Raul, thanks for the patch, it actually looks pretty good to me. What are the remaining tasks?

        Show
        Michi Mutsuzaki added a comment - Hi Raul, thanks for the patch, it actually looks pretty good to me. What are the remaining tasks?
        Hide
        Raul Gutierrez Segales added a comment -

        Thanks for the quick reply Michi. What's left is making sure it'll work for win32 (i.e.: ifdefs for the socket stuff, etc. - i don't have windows machines so i have no way to test it, though i can easily at least cover the basics) and perhaps adding some more tests to ensure backwards compatibility, etc. (i.e.: when talking with a non read-only server).

        Those are the two main things, besides general testing.

        Show
        Raul Gutierrez Segales added a comment - Thanks for the quick reply Michi. What's left is making sure it'll work for win32 (i.e.: ifdefs for the socket stuff, etc. - i don't have windows machines so i have no way to test it, though i can easily at least cover the basics) and perhaps adding some more tests to ensure backwards compatibility, etc. (i.e.: when talking with a non read-only server). Those are the two main things, besides general testing.
        Hide
        Raul Gutierrez Segales added a comment -

        hi Michi Mutsuzaki, i've updated the patch so that:

        a) tests pass
        b) it should compile on win32
        c) small refactoring of the #ifdef win32 blocks because things were getting confused

        let me know what you think! cc: Flavio Junqueira, Thawan Kooburat

        Show
        Raul Gutierrez Segales added a comment - hi Michi Mutsuzaki , i've updated the patch so that: a) tests pass b) it should compile on win32 c) small refactoring of the #ifdef win32 blocks because things were getting confused let me know what you think! cc: Flavio Junqueira , Thawan Kooburat
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12649743/ZOOKEEPER-827.patch
        against trunk revision 1601516.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 27 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2129//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2129//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2129//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12649743/ZOOKEEPER-827.patch against trunk revision 1601516. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 27 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2129//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2129//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2129//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        I'm getting this error:

        src/zookeeper.c: In function 'zookeeper_send':
        src/zookeeper.c:249:28: error: 'MSG_NOSIGNAL' undeclared (first use in this function)
        

        MSG_NOSIGNAL is being defined inside a _WINDOWS ifdef block.

        Show
        Flavio Junqueira added a comment - I'm getting this error: src/zookeeper.c: In function 'zookeeper_send': src/zookeeper.c:249:28: error: 'MSG_NOSIGNAL' undeclared (first use in this function) MSG_NOSIGNAL is being defined inside a _WINDOWS ifdef block.
        Hide
        Raul Gutierrez Segales added a comment -

        Thanks for the review Flavio Junqueira. So the last version of the patch has:

         #ifdef _WINDOWS
        -static int zookeeper_send(SOCKET s, const void* buf, int len)
        +typedef SOCKET socket_t;
        +typedef int sendsize_t;
        +#define SEND_FLAGS  0
         #else
        -static ssize_t zookeeper_send(int s, const void* buf, size_t len)
        +typedef int socket_t;
        +typedef ssize_t sendsize_t;
        +#define SEND_FLAGS  MSG_NOSIGNAL
         #endif
        

        why would #ifdef _WINDOWS not be the path inside Win? Or is that macro not available on all Win platforms?

        Show
        Raul Gutierrez Segales added a comment - Thanks for the review Flavio Junqueira . So the last version of the patch has: #ifdef _WINDOWS -static int zookeeper_send(SOCKET s, const void* buf, int len) +typedef SOCKET socket_t; +typedef int sendsize_t; +#define SEND_FLAGS 0 #else -static ssize_t zookeeper_send(int s, const void* buf, size_t len) +typedef int socket_t; +typedef ssize_t sendsize_t; +#define SEND_FLAGS MSG_NOSIGNAL #endif why would #ifdef _WINDOWS not be the path inside Win? Or is that macro not available on all Win platforms?
        Hide
        Raul Gutierrez Segales added a comment -

        Hmm, looks like we want #ifdef WIN32 as per http://msdn.microsoft.com/en-us/library/b0084kay%28VS.100%29.aspx?

        All other places in that file use that macro, should we use that and ditch _WINDOWS which doesn't seem documented?

        Show
        Raul Gutierrez Segales added a comment - Hmm, looks like we want #ifdef WIN32 as per http://msdn.microsoft.com/en-us/library/b0084kay%28VS.100%29.aspx? All other places in that file use that macro, should we use that and ditch _WINDOWS which doesn't seem documented?
        Hide
        Flavio Junqueira added a comment -

        Using _WIN32 does seem better, and I also like the idea of making it uniform.

        Show
        Flavio Junqueira added a comment - Using _WIN32 does seem better, and I also like the idea of making it uniform.
        Hide
        Raul Gutierrez Segales added a comment -

        Made the Windows related #ifdefs consistent across zookeeper.c.

        cc: Flavio Junqueira

        Show
        Raul Gutierrez Segales added a comment - Made the Windows related #ifdefs consistent across zookeeper.c. cc: Flavio Junqueira
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12651217/ZOOKEEPER-827.patch
        against trunk revision 1601516.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2137//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2137//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2137//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12651217/ZOOKEEPER-827.patch against trunk revision 1601516. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2137//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2137//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2137//console This message is automatically generated.
        Hide
        Raul Gutierrez Segales added a comment -

        Hmm, weird — a java test failed. I'll look into it.

        Show
        Raul Gutierrez Segales added a comment - Hmm, weird — a java test failed. I'll look into it.
        Hide
        Raul Gutierrez Segales added a comment -

        Actually, ignoring the Java failure for now since it's unrelated.

        Michi Mutsuzaki, Flavio Junqueira: could you guys take another look please?

        Show
        Raul Gutierrez Segales added a comment - Actually, ignoring the Java failure for now since it's unrelated. Michi Mutsuzaki , Flavio Junqueira : could you guys take another look please?
        Hide
        Flavio Junqueira added a comment -

        I'm having a look. Thanks for the heads up.

        Show
        Flavio Junqueira added a comment - I'm having a look. Thanks for the heads up.
        Hide
        Flavio Junqueira added a comment -

        Actually, would you mind uploading it to the review board, please? I have a bunch of small things, and it'd be easier this way.

        Show
        Flavio Junqueira added a comment - Actually, would you mind uploading it to the review board, please? I have a bunch of small things, and it'd be easier this way.
        Hide
        Raul Gutierrez Segales added a comment -
        Show
        Raul Gutierrez Segales added a comment - Sure, Flavio Junqueira , here you go: https://reviews.apache.org/r/23081/ .
        Hide
        Flavio Junqueira added a comment - - edited

        +1, looks good to me. This is based on the patch in the review board, I think Raul Gutierrez Segales hasn't updated the jira patch yet.

        Show
        Flavio Junqueira added a comment - - edited +1, looks good to me. This is based on the patch in the review board, I think Raul Gutierrez Segales hasn't updated the jira patch yet.
        Hide
        Raul Gutierrez Segales added a comment -

        version of the patch (available on reviewboard too)

        Show
        Raul Gutierrez Segales added a comment - version of the patch (available on reviewboard too)
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12653416/ZOOKEEPER-827.patch
        against trunk revision 1606841.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2167//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2167//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2167//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12653416/ZOOKEEPER-827.patch against trunk revision 1606841. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2167//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2167//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2167//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        hey raul, I just realized it doesn't compile on mac os. We need to do something like this to get it to compile:

        #ifdef _WIN32
        typedef SOCKET socket_t;
        typedef int sendsize_t;
        #define SEND_FLAGS  0
        #else
        #ifdef __APPLE__
        #define MSG_NOSIGNAL SO_NOSIGPIPE
        #endif
        typedef int socket_t;
        typedef ssize_t sendsize_t;
        #define SEND_FLAGS  MSG_NOSIGNAL
        #endif
        

        This is in zookeeper.c. If you agree, could you update the patch, please?

        Show
        Flavio Junqueira added a comment - hey raul, I just realized it doesn't compile on mac os. We need to do something like this to get it to compile: #ifdef _WIN32 typedef SOCKET socket_t; typedef int sendsize_t; #define SEND_FLAGS 0 #else #ifdef __APPLE__ #define MSG_NOSIGNAL SO_NOSIGPIPE #endif typedef int socket_t; typedef ssize_t sendsize_t; #define SEND_FLAGS MSG_NOSIGNAL #endif This is in zookeeper.c. If you agree, could you update the patch, please?
        Hide
        Raul Gutierrez Segales added a comment -

        Oh, thanks for catching this Flavio Junqueira - will update right away and I'll try to find a mac to test it beforehand too. Thanks!

        Show
        Raul Gutierrez Segales added a comment - Oh, thanks for catching this Flavio Junqueira - will update right away and I'll try to find a mac to test it beforehand too. Thanks!
        Hide
        Raul Gutierrez Segales added a comment -

        Updated the RB (https://reviews.apache.org/r/23081/), Flavio Junqueira. I know it compiles in OS X, but haven't tested tho. Thanks!

        Show
        Raul Gutierrez Segales added a comment - Updated the RB ( https://reviews.apache.org/r/23081/ ), Flavio Junqueira . I know it compiles in OS X, but haven't tested tho. Thanks!
        Hide
        Raul Gutierrez Segales added a comment -

        last version available in the reviewboard as well.

        Show
        Raul Gutierrez Segales added a comment - last version available in the reviewboard as well.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12654339/ZOOKEEPER-827.patch
        against trunk revision 1607774.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2177//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2177//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2177//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12654339/ZOOKEEPER-827.patch against trunk revision 1607774. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2177//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2177//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2177//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        +1. Thanks, Raul Gutierrez Segales. Committed revision 1608620.

        Show
        Flavio Junqueira added a comment - +1. Thanks, Raul Gutierrez Segales . Committed revision 1608620.
        Hide
        Raul Gutierrez Segales added a comment -

        Thanks a lot for the review & feedback Flavio Junqueira!

        Show
        Raul Gutierrez Segales added a comment - Thanks a lot for the review & feedback Flavio Junqueira !
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in ZooKeeper-trunk #2359 (See https://builds.apache.org/job/ZooKeeper-trunk/2359/)
        ZOOKEEPER-827. enable r/o mode in C client library (rgs via fpj) (fpj: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608620)

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/c/Makefile.am
        • /zookeeper/trunk/src/c/README
        • /zookeeper/trunk/src/c/include/zookeeper.h
        • /zookeeper/trunk/src/c/src/addrvec.c
        • /zookeeper/trunk/src/c/src/addrvec.h
        • /zookeeper/trunk/src/c/src/cli.c
        • /zookeeper/trunk/src/c/src/load_gen.c
        • /zookeeper/trunk/src/c/src/zk_adaptor.h
        • /zookeeper/trunk/src/c/src/zookeeper.c
        • /zookeeper/trunk/src/c/tests/TestClientRetry.cc
        • /zookeeper/trunk/src/c/tests/TestReadOnlyClient.cc
        • /zookeeper/trunk/src/c/tests/WatchUtil.h
        • /zookeeper/trunk/src/c/tests/ZKMocks.cc
        • /zookeeper/trunk/src/c/tests/ZKMocks.h
        • /zookeeper/trunk/src/c/tests/quorum.cfg
        • /zookeeper/trunk/src/c/tests/zkServer.sh
        Show
        Hudson added a comment - SUCCESS: Integrated in ZooKeeper-trunk #2359 (See https://builds.apache.org/job/ZooKeeper-trunk/2359/ ) ZOOKEEPER-827 . enable r/o mode in C client library (rgs via fpj) (fpj: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608620 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/c/Makefile.am /zookeeper/trunk/src/c/README /zookeeper/trunk/src/c/include/zookeeper.h /zookeeper/trunk/src/c/src/addrvec.c /zookeeper/trunk/src/c/src/addrvec.h /zookeeper/trunk/src/c/src/cli.c /zookeeper/trunk/src/c/src/load_gen.c /zookeeper/trunk/src/c/src/zk_adaptor.h /zookeeper/trunk/src/c/src/zookeeper.c /zookeeper/trunk/src/c/tests/TestClientRetry.cc /zookeeper/trunk/src/c/tests/TestReadOnlyClient.cc /zookeeper/trunk/src/c/tests/WatchUtil.h /zookeeper/trunk/src/c/tests/ZKMocks.cc /zookeeper/trunk/src/c/tests/ZKMocks.h /zookeeper/trunk/src/c/tests/quorum.cfg /zookeeper/trunk/src/c/tests/zkServer.sh

          People

          • Assignee:
            Raul Gutierrez Segales
            Reporter:
            Sergey Doroshenko
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development