ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-814

monitoring scripts are missing apache license headers

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: contrib
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Andrei, I just realized that src/contrib/monitoring files are missing apache license headers. Please add them (in particular any script files like python, see similar files in svn for examples - in some cases like README it's not strictly necessary.)

      You can run the RAT tool to verify (see build.xml or http://incubator.apache.org/rat/)

        Activity

        Hide
        Andrei Savu added a comment -

        Added license headers to all files. Sorry about missing this in the first place.

        Show
        Andrei Savu added a comment - Added license headers to all files. Sorry about missing this in the first place.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12449427/ZOOKEEPER-814.patch
        against trunk revision 963957.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449427/ZOOKEEPER-814.patch against trunk revision 963957. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        +1 the patch looks good.

        Andrei,
        I think the monitoring tools and scripts are quite useful, though it would have been great to have forrest docs for all the plugins like ganglia/others, so that we can publish them as part of the release documentation!! Please consider adding forrest documentation (it should not be hard at all)!!! It would be really good to have admin documentation link to these forrest docs in case they want to use it!

        Having all the documentation as forrest docs and availalbe on the documentation website (as part of release) will highly increase the adoption of such a plugin!

        Show
        Mahadev konar added a comment - +1 the patch looks good. Andrei, I think the monitoring tools and scripts are quite useful, though it would have been great to have forrest docs for all the plugins like ganglia/others, so that we can publish them as part of the release documentation!! Please consider adding forrest documentation (it should not be hard at all)!!! It would be really good to have admin documentation link to these forrest docs in case they want to use it! Having all the documentation as forrest docs and availalbe on the documentation website (as part of release) will highly increase the adoption of such a plugin!
        Hide
        Mahadev konar added a comment -

        I just committed this.

        thanks andrei!

        Show
        Mahadev konar added a comment - I just committed this. thanks andrei!
        Hide
        Andrei Savu added a comment -

        thanks Mahadev!

        Show
        Andrei Savu added a comment - thanks Mahadev!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #887 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/887/)
        ZOOKEEPER-814. monitoring scripts are missing apache license headers (andrei savu via mahadev)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #887 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/887/ ) ZOOKEEPER-814 . monitoring scripts are missing apache license headers (andrei savu via mahadev)

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development