ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-797

c client source with AI_ADDRCONFIG cannot be compiled with early glibc

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.1
    • Fix Version/s: 3.4.0
    • Component/s: c client
    • Labels:
      None
    • Environment:

      linux 2.6.9

    • Hadoop Flags:
      Reviewed
    • Tags:
      c client

      Description

      c client source with AI_ADDRCONFIG cannot be compiled with early glibc (before 2.3.3)

        Activity

        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #869 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/)
        ZOOKEEPER-797 c client source with AI_ADDRCONFIG cannot be compiled with early glibc

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #869 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/ ) ZOOKEEPER-797 c client source with AI_ADDRCONFIG cannot be compiled with early glibc
        Hide
        Patrick Hunt added a comment -

        +1, thanks Qian! (not test necessary here give we don't test against multiple versions of gcc)

        Show
        Patrick Hunt added a comment - +1, thanks Qian! (not test necessary here give we don't test against multiple versions of gcc)
        Hide
        Qian Ye added a comment -

        Hi guys, do I need to add any tests for this patch?

        Show
        Qian Ye added a comment - Hi guys, do I need to add any tests for this patch?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12448273/ZOOKEEPER-797.patch
        against trunk revision 958096.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/89/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/89/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/89/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448273/ZOOKEEPER-797.patch against trunk revision 958096. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/89/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/89/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/89/console This message is automatically generated.

          People

          • Assignee:
            Qian Ye
            Reporter:
            Qian Ye
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development