Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-783

committedLog in ZKDatabase is not properly synchronized

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 3.3.1
    • 3.3.2, 3.4.0
    • server
    • None
    • Reviewed

    Description

      ZKDatabase.getCommittedLog() returns a reference to the LinkedList<Proposal> committedLog in ZKDatabase. This is then iterated over by at least one caller.

      I have seen a bug that causes a NPE in LinkedList.clear on committedLog, which I am pretty sure is due to the lack of synchronization. This bug has not been apparent in normal ZK operation, but in code that I have that starts and stops a ZK server in process repeatedly (clear() is called from ZooKeeperServerMain.shutdown()).

      It's better style to defensively copy the list in getCommittedLog, and to synchronize on the list in ZKDatabase.clear.

      Attachments

        1. ZOOKEEPER-783.patch
          0.8 kB
          Henry Robinson

        Activity

          People

            henryr Henry Robinson
            henryr Henry Robinson
            Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: