Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: contrib
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Zkgraph is a log viewer for zookeeper. It can handle transaction logs and message logs. There are currently two view.

      a) Server view
      The server view shows the interactions between the different servers in an ensemble. The X axis represents time.

      • Exceptions show up as red dots. Hovering your mouse over them will give you more details of the exception
      • The colour of the line represents the election state of the server.
      • orange means LOOKING for leader
      • dark green means the server is the leader
      • light green means the server is following a leader
      • yellow means there isn't enough information to determine the state of the server.
      • The gray arrows denote election messages between servers. Pink dashed arrows are messages that were sent but never delivered.

      b) Session view
      The session view shows the lifetime of sessions on a server. Use the time filter to narrow down the view. Any more than about 2000 events will take a long time to view in your browser.
      The Y axis represents time in this case. Each line is a session. The black dots represent events on the session. You can click on the black dots for more details of the event.

      2 - Compiling & Running

      Run "ant jar" in src/contrib/zkgraph/. This will download all dependencies and compile all the zkgraph code.

      Once compilation has finished, you can run it the the zkgraph.sh script in src/contrib/zkgraph/bin. This will start and embedded web server on you machine. Navigate to http://localhost:8182/graph/main.html.

      1. ZOOKEEPER-773.diff
        390 kB
        Ivan Kelly
      2. test5.logs.tgz
        5 kB
        Patrick Hunt
      3. ZOOKEEPER-773.binaries.tgz
        2 kB
        Ivan Kelly

        Activity

        Ivan Kelly created issue -
        Ivan Kelly made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-773.diff [ 12444204 ]
        Hide
        Ivan Kelly added a comment -

        This is a first drop of the patch, containing the basic visualisations. Im currently working on a filtering system to narrow down the logs, but it'll be next week before thats done. I will post another patch when it is.

        Show
        Ivan Kelly added a comment - This is a first drop of the patch, containing the basic visualisations. Im currently working on a filtering system to narrow down the logs, but it'll be next week before thats done. I will post another patch when it is.
        Ivan Kelly made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Ivan Kelly made changes -
        Attachment ZOOKEEPER-773.diff [ 12444204 ]
        Ivan Kelly made changes -
        Attachment ZOOKEEPER-773.diff [ 12445558 ]
        Hide
        Ivan Kelly added a comment -

        going to resubmit

        Show
        Ivan Kelly added a comment - going to resubmit
        Ivan Kelly made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Ivan Kelly added a comment -

        Added simple log view, some graphing, error handling, loading screen and filters.

        Show
        Ivan Kelly added a comment - Added simple log view, some graphing, error handling, loading screen and filters.
        Ivan Kelly made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Ivan Kelly added a comment -

        Writing doc on how to use filters now, will upload when done.

        Show
        Ivan Kelly added a comment - Writing doc on how to use filters now, will upload when done.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12445558/ZOOKEEPER-773.diff
        against trunk revision 947063.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/107/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/107/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445558/ZOOKEEPER-773.diff against trunk revision 947063. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/107/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/107/console This message is automatically generated.
        Hide
        Ivan Kelly added a comment -

        adding readme

        Show
        Ivan Kelly added a comment - adding readme
        Ivan Kelly made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Ivan Kelly made changes -
        Attachment ZOOKEEPER-773.diff [ 12445558 ]
        Hide
        Ivan Kelly added a comment -

        added README

        Show
        Ivan Kelly added a comment - added README
        Ivan Kelly made changes -
        Attachment ZOOKEEPER-773.diff [ 12445568 ]
        Hide
        Ivan Kelly added a comment -

        adding README

        Show
        Ivan Kelly added a comment - adding README
        Ivan Kelly made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12445568/ZOOKEEPER-773.diff
        against trunk revision 947063.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/108/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/108/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/108/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445568/ZOOKEEPER-773.diff against trunk revision 947063. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/108/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/108/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/108/console This message is automatically generated.
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Patrick Hunt made changes -
        Fix Version/s 3.4.0 [ 12314469 ]
        Hide
        Patrick Hunt added a comment -

        naming "zkgraph" is not very descriptive - ppl may think it graphs zk namespace? How about "logvisualizer" or "loggrapher" (something indicating that the contrib visualizes the log). Although even this is potentially misleading (txn log vs log4j log). You have a great description at the top of the readme which is good though. (perhaps indicate that this is log4j log and not txn log?)

        lib dir missing from patch (build fails, I created by hand and it was fine, good to get into patch though)

        bin scripts are not executable - perhaps update patch, also committer should chmod the scripts to add "x" if missing

        add apache license to zkgraph.css

        LogFormatter.java has license twice

        For some reason the app itself does not work for me. I click on the links (I tried both chrome and firefox) but nothing happens. "add log" for example, I click that and nothing at all happens. Here's the console that's running the zkgraph.sh script (this is the entire content of the console):

        $ bin/zkgraph.sh
        MergedLogSource(size=0, start=0, end=0)
        2010-06-01 09:52:35.695:INFO::Logging to StdErrLog::DEBUG=false via org.eclipse.jetty.util.log.StdErrLog
        2010-06-01 09:52:35.733:INFO::jetty-7.0.1.v20091125
        2010-06-01 09:52:35.969:INFO::Started SelectChannelConnector@0.0.0.0:8182
        log4j:WARN No appenders could be found for logger (org.apache.zookeeper.graph.servlets.NumEvents).
        log4j:WARN Please initialize the log4j system properly.

        Show
        Patrick Hunt added a comment - naming "zkgraph" is not very descriptive - ppl may think it graphs zk namespace? How about "logvisualizer" or "loggrapher" (something indicating that the contrib visualizes the log). Although even this is potentially misleading (txn log vs log4j log). You have a great description at the top of the readme which is good though. (perhaps indicate that this is log4j log and not txn log?) lib dir missing from patch (build fails, I created by hand and it was fine, good to get into patch though) bin scripts are not executable - perhaps update patch, also committer should chmod the scripts to add "x" if missing add apache license to zkgraph.css LogFormatter.java has license twice For some reason the app itself does not work for me. I click on the links (I tried both chrome and firefox) but nothing happens. "add log" for example, I click that and nothing at all happens. Here's the console that's running the zkgraph.sh script (this is the entire content of the console): $ bin/zkgraph.sh MergedLogSource(size=0, start=0, end=0) 2010-06-01 09:52:35.695:INFO::Logging to StdErrLog::DEBUG=false via org.eclipse.jetty.util.log.StdErrLog 2010-06-01 09:52:35.733:INFO::jetty-7.0.1.v20091125 2010-06-01 09:52:35.969:INFO::Started SelectChannelConnector@0.0.0.0:8182 log4j:WARN No appenders could be found for logger (org.apache.zookeeper.graph.servlets.NumEvents). log4j:WARN Please initialize the log4j system properly.
        Hide
        Patrick Hunt added a comment -

        I'm on karmic btw (ubuntu) with the latest 1.6 jvm.

        Show
        Patrick Hunt added a comment - I'm on karmic btw (ubuntu) with the latest 1.6 jvm.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12445568/ZOOKEEPER-773.diff
        against trunk revision 947063.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/111/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/111/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/111/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445568/ZOOKEEPER-773.diff against trunk revision 947063. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/111/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/111/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/111/console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Canceling patch while Ivan looks into chrome issues and other comments I identified in my review.

        Show
        Patrick Hunt added a comment - Canceling patch while Ivan looks into chrome issues and other comments I identified in my review.
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Ivan Kelly added a comment -

        Renamed to loggraph. Works for chrome (chrome doesn't like for each). Minor changes for comments.

        Show
        Ivan Kelly added a comment - Renamed to loggraph. Works for chrome (chrome doesn't like for each). Minor changes for comments.
        Ivan Kelly made changes -
        Attachment ZOOKEEPER-773_2.diff [ 12446146 ]
        Hide
        Patrick Hunt added a comment -

        Ivan, works better now in chrome, however still does not work at all in 3.5.9 of firefox. I even created a new clean profile in firefox but that did not help. I click on the links and nothing happens.

        Issues in chrome:

        1) I created a 5 server ensemble and started it. The quorum formed with 1-4 as followers and 5 as leader. I opened all the logs in loggraph and selected "server view". only servers 1-4 were displayed, 5 is missing. is there some requirement on the zk version? I'm using it with trunk.

        2) the file browser randomizes the file/directory list, that makes it very hard to navigate

        3) do you want to change zkgraph references to loggraph in the contrib? for example in the readme? (try doing grep -Ri zkgraph at the toplevel)

        Show
        Patrick Hunt added a comment - Ivan, works better now in chrome, however still does not work at all in 3.5.9 of firefox. I even created a new clean profile in firefox but that did not help. I click on the links and nothing happens. Issues in chrome: 1) I created a 5 server ensemble and started it. The quorum formed with 1-4 as followers and 5 as leader. I opened all the logs in loggraph and selected "server view". only servers 1-4 were displayed, 5 is missing. is there some requirement on the zk version? I'm using it with trunk. 2) the file browser randomizes the file/directory list, that makes it very hard to navigate 3) do you want to change zkgraph references to loggraph in the contrib? for example in the readme? (try doing grep -Ri zkgraph at the toplevel)
        Hide
        Ivan Kelly added a comment -

        Finished renaming to loggraph. Fixed the ordering of files in selector. Minor build fixes

        Show
        Ivan Kelly added a comment - Finished renaming to loggraph. Fixed the ordering of files in selector. Minor build fixes
        Ivan Kelly made changes -
        Attachment ZOOKEEPER-773.binaries.tgz [ 12446345 ]
        Attachment ZOOKEEPER-773.diff [ 12446346 ]
        Ivan Kelly made changes -
        Attachment ZOOKEEPER-773.diff [ 12445568 ]
        Ivan Kelly made changes -
        Attachment ZOOKEEPER-773_2.diff [ 12446146 ]
        Hide
        Ivan Kelly added a comment -

        I've verified with firefox on another machine, running ubuntu lucid + Firefox 3.6.3 . What does dpkg -l xul-ext* and dpkg -l firefox* tell you? Does anything show up in the javascript console at all?

        1) This is probably due to the detection of the server ID being a bit dodgy. Still not show how to fix this.

        2) Fixed

        3) All renamed.

        I just uploaded a patch with the fixes. There's also a tarball with the binaries in it.

        Show
        Ivan Kelly added a comment - I've verified with firefox on another machine, running ubuntu lucid + Firefox 3.6.3 . What does dpkg -l xul-ext* and dpkg -l firefox* tell you? Does anything show up in the javascript console at all? 1) This is probably due to the detection of the server ID being a bit dodgy. Still not show how to fix this. 2) Fixed 3) All renamed. I just uploaded a patch with the fixes. There's also a tarball with the binaries in it.
        Hide
        Patrick Hunt added a comment - - edited
        $ dpkg -l xul-ext*
        No packages found matching xul-ext*.
        
        $ dpkg -l firefox*
        Desired=Unknown/Install/Remove/Purge/Hold
        | Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend
        |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
        ||/ Name                   Version                Description
        +++-======================-======================-============================================================
        ii  firefox                3.5.9+nobinonly-0ubunt meta package for the popular mozilla web browser
        un  firefox-2              <none>                 (no description available)
        un  firefox-3.0            <none>                 (no description available)
        un  firefox-3.0-branding   <none>                 (no description available)
        un  firefox-3.0-dom-inspec <none>                 (no description available)
        un  firefox-3.0-gnome-supp <none>                 (no description available)
        un  firefox-3.0-venkman    <none>                 (no description available)
        un  firefox-3.1            <none>                 (no description available)
        un  firefox-3.1-branding   <none>                 (no description available)
        un  firefox-3.1-gnome-supp <none>                 (no description available)
        ii  firefox-3.5            3.5.9+nobinonly-0ubunt safe and easy web browser from Mozilla
        ii  firefox-3.5-branding   3.5.9+nobinonly-0ubunt Package that ships the firefox branding
        ii  firefox-3.5-gnome-supp 3.5.9+nobinonly-0ubunt Support for Gnome in Mozilla Firefox
        un  firefox-dom-inspector  <none>                 (no description available)
        ii  firefox-gnome-support  3.5.9+nobinonly-0ubunt meta package pointing to the latest gnome-support package fo
        
        Show
        Patrick Hunt added a comment - - edited $ dpkg -l xul-ext* No packages found matching xul-ext*. $ dpkg -l firefox* Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Description +++-======================-======================-============================================================ ii firefox 3.5.9+nobinonly-0ubunt meta package for the popular mozilla web browser un firefox-2 <none> (no description available) un firefox-3.0 <none> (no description available) un firefox-3.0-branding <none> (no description available) un firefox-3.0-dom-inspec <none> (no description available) un firefox-3.0-gnome-supp <none> (no description available) un firefox-3.0-venkman <none> (no description available) un firefox-3.1 <none> (no description available) un firefox-3.1-branding <none> (no description available) un firefox-3.1-gnome-supp <none> (no description available) ii firefox-3.5 3.5.9+nobinonly-0ubunt safe and easy web browser from Mozilla ii firefox-3.5-branding 3.5.9+nobinonly-0ubunt Package that ships the firefox branding ii firefox-3.5-gnome-supp 3.5.9+nobinonly-0ubunt Support for Gnome in Mozilla Firefox un firefox-dom-inspector <none> (no description available) ii firefox-gnome-support 3.5.9+nobinonly-0ubunt meta package pointing to the latest gnome-support package fo
        Hide
        Patrick Hunt added a comment -

        test5.logs.tgz shows an issue with the server view - server 5 (leader) is not displayed.

        Show
        Patrick Hunt added a comment - test5.logs.tgz shows an issue with the server view - server 5 (leader) is not displayed.
        Patrick Hunt made changes -
        Attachment test5.logs.tgz [ 12446503 ]
        Hide
        Patrick Hunt added a comment -

        Ivan, I noticed one issue with packaging. The build.xml for loggraph package is including many jars, typically we don't do this (for example we don't pull in netty as part of bookkeeper packaging).

        Can you address this? Try doing a "ant tar" and look at the resulting archive - it should not be including the external jars (at least we don't do this for many of the other contribs today, see bookeeper and rest contribs for examples)

        Show
        Patrick Hunt added a comment - Ivan, I noticed one issue with packaging. The build.xml for loggraph package is including many jars, typically we don't do this (for example we don't pull in netty as part of bookkeeper packaging). Can you address this? Try doing a "ant tar" and look at the resulting archive - it should not be including the external jars (at least we don't do this for many of the other contribs today, see bookeeper and rest contribs for examples)
        Hide
        Ivan Kelly added a comment -

        Fixed packaging issue.

        Show
        Ivan Kelly added a comment - Fixed packaging issue.
        Ivan Kelly made changes -
        Attachment ZOOKEEPER-773.diff [ 12446518 ]
        Ivan Kelly made changes -
        Attachment ZOOKEEPER-773.diff [ 12446346 ]
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12446518/ZOOKEEPER-773.diff
        against trunk revision 947063.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/114/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/114/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/114/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446518/ZOOKEEPER-773.diff against trunk revision 947063. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/114/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/114/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/114/console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        +1, thanks Ivan, this looks to be a very useful tool!

        Show
        Patrick Hunt added a comment - +1, thanks Ivan, this looks to be a very useful tool!
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #839 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/839/)
        ZOOKEEPER-773. Log visualisation

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #839 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/839/ ) ZOOKEEPER-773 . Log visualisation
        Mahadev konar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ivan Kelly
            Reporter:
            Ivan Kelly
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Development