ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-764

Observer elected leader due to inconsistent voting view

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.1, 3.4.0
    • Component/s: quorum
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In ZOOKEEPER-690, we noticed that an observer was being elected, and Henry proposed a patch to fix the issue. However, it seems that the patch does not solve the issue one user (Alan Cabrera) has observed. Given that we would like to fix this issue, and to work separately with Alan to determine the problem with his setup, I'm creating this jira and re-posting Henry's patch.

      1. ZOOKEEPER-764_3_3_1.patch
        13 kB
        Henry Robinson
      2. ZOOKEEPER-690.patch
        11 kB
        Flavio Junqueira

        Issue Links

          Activity

          Flavio Junqueira created issue -
          Hide
          Flavio Junqueira added a comment -

          +1, as I have already stated in ZOOKEEPER-690.

          Show
          Flavio Junqueira added a comment - +1, as I have already stated in ZOOKEEPER-690 .
          Flavio Junqueira made changes -
          Field Original Value New Value
          Attachment ZOOKEEPER-690.patch [ 12443646 ]
          Hide
          Mahadev konar added a comment -

          flavio and henry,

          Should this patch go into 3.3 release? Looks like it should. Is there any reason its not marked PA?

          Show
          Mahadev konar added a comment - flavio and henry, Should this patch go into 3.3 release? Looks like it should. Is there any reason its not marked PA?
          Mahadev konar made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Flavio Junqueira added a comment -

          My bad, forgot to mark it PA. It should go to 3.3.1. Thanks, Mahadev!

          Show
          Flavio Junqueira added a comment - My bad, forgot to mark it PA. It should go to 3.3.1. Thanks, Mahadev!
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12443646/ZOOKEEPER-690.patch
          against trunk revision 941056.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/81/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/81/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/81/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443646/ZOOKEEPER-690.patch against trunk revision 941056. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/81/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/81/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/81/console This message is automatically generated.
          Patrick Hunt made changes -
          Fix Version/s 3.4.0 [ 12314469 ]
          Patrick Hunt made changes -
          Link This issue is related to ZOOKEEPER-690 [ ZOOKEEPER-690 ]
          Hide
          Henry Robinson added a comment -

          Patch to apply against 3_3_1

          Show
          Henry Robinson added a comment - Patch to apply against 3_3_1
          Henry Robinson made changes -
          Attachment ZOOKEEPER-764_3_3_1.patch [ 12443773 ]
          Hide
          Mahadev konar added a comment -

          I just committed this. thanks henry and flavio!

          Show
          Mahadev konar added a comment - I just committed this. thanks henry and flavio!
          Mahadev konar made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Mahadev konar made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          20m 8s 1 Mahadev konar 04/May/10 23:01
          Patch Available Patch Available Resolved Resolved
          1d 26m 1 Mahadev konar 05/May/10 23:27
          Resolved Resolved Closed Closed
          566d 20h 54m 1 Mahadev konar 23/Nov/11 19:22

            People

            • Assignee:
              Henry Robinson
              Reporter:
              Flavio Junqueira
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development