Details

    • Hadoop Flags:
      Reviewed
    • Release Note:
      fixed numerous misspellings of "succesfully" in the c client and python bindings

      Description

      When testing the debian package of zookeeper with the standard tool "lintian", it fills my screen with complains about the misspelling of "succesfully" in several places of the zkpython contrib. Please be so kind to correct this, when you touch the code the next time. Thanks!

      1. ZOOKEEPER-754.patch
        19 kB
        Andrei Savu
      2. ZOOKEEPER-754.patch
        6 kB
        Andrei Savu

        Activity

        Hide
        Patrick Hunt added a comment -

        +1, Thanks Andrei! Committed to 3.3 branch and trunk.

        Show
        Patrick Hunt added a comment - +1, Thanks Andrei! Committed to 3.3 branch and trunk.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12443009/ZOOKEEPER-754.patch
        against trunk revision 938212.

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/76/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/76/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/76/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443009/ZOOKEEPER-754.patch against trunk revision 938212. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/76/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/76/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/76/console This message is automatically generated.
        Hide
        Andrei Savu added a comment -

        Fixed patch. It will replace all errors in all the files.

        Show
        Andrei Savu added a comment - Fixed patch. It will replace all errors in all the files.
        Hide
        Patrick Hunt added a comment -

        Better, but running this at the toplevel directory:

        egrep -R succesfully src

        shows a number of issues in zookeeper.c and zookeeper.h (under src/c/..., not contrib)

        Makes sense to clean those up at the same time (then click "submit patch" on this page to move the workflow to the next step)

        Thanks!

        Show
        Patrick Hunt added a comment - Better, but running this at the toplevel directory: egrep -R succesfully src shows a number of issues in zookeeper.c and zookeeper.h (under src/c/..., not contrib) Makes sense to clean those up at the same time (then click "submit patch" on this page to move the workflow to the next step) Thanks!
        Hide
        Andrei Savu added a comment -

        The patch affects a single file: pyzk_docstrings.h. It applies cleanly on trunk and on the latest release (3.3.0).

        Show
        Andrei Savu added a comment - The patch affects a single file: pyzk_docstrings.h. It applies cleanly on trunk and on the latest release (3.3.0).
        Hide
        Patrick Hunt added a comment -

        Hi Thomas, this would be a great opportunity for someone to give back to the community, and gain some experience
        as an Apache ZooKeeper Contributor at the same time. Seems like you have the data at hand, would you mind contributing a patch?
        http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute

        Show
        Patrick Hunt added a comment - Hi Thomas, this would be a great opportunity for someone to give back to the community, and gain some experience as an Apache ZooKeeper Contributor at the same time. Seems like you have the data at hand, would you mind contributing a patch? http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Thomas Koch
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development