ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-735

cppunit test testipv6 assumes that the machine is ipv6 enabled.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.1, 3.4.0
    • Component/s: tests
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The test should be fixed so that it runs only if ipv6 is enabled and does not run if ipv6 is not enabled.

        Activity

        Hide
        Mahadev konar added a comment -

        this patch fixes the issue. I have tested it on ipv6/ipv4 redhat/ubuntu machines. The patch seems pretty general to be working on other platforms. Do give it a try if you have a different platform.

        Show
        Mahadev konar added a comment - this patch fixes the issue. I have tested it on ipv6/ipv4 redhat/ubuntu machines. The patch seems pretty general to be working on other platforms. Do give it a try if you have a different platform.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12441097/ZOOKEEPER-735.patch
        against trunk revision 929564.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/48/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/48/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/48/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12441097/ZOOKEEPER-735.patch against trunk revision 929564. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/48/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/48/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/48/console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        +1, looks good to me. I was able to run configure on cygwin 1.5 and it detected that there was no ipv6 (is none).
        Ran on my ubuntu system and detected that there was ipv6.

        Show
        Patrick Hunt added a comment - +1, looks good to me. I was able to run configure on cygwin 1.5 and it detected that there was no ipv6 (is none). Ran on my ubuntu system and detected that there was ipv6.
        Hide
        Mahadev konar added a comment -

        I just committed this to trunk and 3.3 branch.

        Show
        Mahadev konar added a comment - I just committed this to trunk and 3.3 branch.

          People

          • Assignee:
            Mahadev konar
            Reporter:
            Mahadev konar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development