ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-720

Use zookeeper-{version}-sources.jar instead of zookeeper-{version}-src.jar to publish sources in the Maven repository

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.3.0
    • Fix Version/s: 3.3.1, 3.4.0
    • Component/s: build
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      The artifact with the sources to be published in the Maven repository should be named $

      {artifactId}-${version}-sources.jar not ${artifactId}

      -$

      {version}

      -src.jar.

      See also: http://maven.apache.org/guides/mini/guide-central-repository-upload.html and ZOOKEEPER-224

        Activity

        Paolo Castagna created issue -
        Paolo Castagna made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Paolo Castagna made changes -
        Attachment ZOOKEEPER-720.patch [ 12439401 ]
        Paolo Castagna made changes -
        Labels maven
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12439401/ZOOKEEPER-720.patch
        against trunk revision 925362.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/34/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/34/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/34/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439401/ZOOKEEPER-720.patch against trunk revision 925362. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/34/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/34/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/34/console This message is automatically generated.
        Hide
        Paolo Castagna added a comment -

        No tests are included, this is a trivial change to the build.xml file.

        Show
        Paolo Castagna added a comment - No tests are included, this is a trivial change to the build.xml file.
        Hide
        Henry Robinson added a comment -

        Patch looks good to me, +1.

        Show
        Henry Robinson added a comment - Patch looks good to me, +1.
        Henry Robinson made changes -
        Hadoop Flags [Reviewed]
        Patrick Hunt made changes -
        Affects Version/s 3.3.0 [ 12313976 ]
        Affects Version/s 3.0.0 [ 12313216 ]
        Patrick Hunt made changes -
        Assignee Paolo Castagna [ castagna ]
        Fix Version/s 3.4.0 [ 12314469 ]
        Hide
        Patrick Hunt added a comment -

        once 3.3.0 goes out officially we should commit this to 3.3 branch and trunk.

        Thanks Paolo!

        Show
        Patrick Hunt added a comment - once 3.3.0 goes out officially we should commit this to 3.3 branch and trunk. Thanks Paolo!
        Hide
        Patrick Hunt added a comment -

        +1, thanks Paolo!

        Show
        Patrick Hunt added a comment - +1, thanks Paolo!
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mahadev konar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Paolo Castagna
            Reporter:
            Paolo Castagna
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development