ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-698

intermittent JMX test failures due to not verifying QuorumPeer shutdown

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: tests
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      in some cases the tests are failing with JMX errors. From the logs I can see that QP was shutdown, however it did not exit it's thread until some time much later. This is causing interference with subsequent tests, causing the test to fail.

      I have a patch that attempts to verify that the QP was shutdown (by joining the thread). It turns out that tests based on QuorumBase do this check (join) however some of the other tests do not. I believe this will address the issue.

        Activity

        Hide
        Patrick Hunt added a comment -

        This patch addresses the problem of verifying that the QPs were actually shut down. Passes my tests and should address this problem.

        Show
        Patrick Hunt added a comment - This patch addresses the problem of verifying that the QPs were actually shut down. Passes my tests and should address this problem.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12438649/ZOOKEEPER-698.patch
        against trunk revision 922442.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 45 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/19/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/19/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/19/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438649/ZOOKEEPER-698.patch against trunk revision 922442. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 45 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/19/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/19/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/19/console This message is automatically generated.
        Hide
        Benjamin Reed added a comment -

        +1 looks good pat. nice cleanup.

        Show
        Benjamin Reed added a comment - +1 looks good pat. nice cleanup.
        Hide
        Patrick Hunt added a comment -

        Committed revision 922459.

        Show
        Patrick Hunt added a comment - Committed revision 922459.
        Hide
        Benjamin Reed added a comment -

        attaching the patch that corresponds to my comment

        Show
        Benjamin Reed added a comment - attaching the patch that corresponds to my comment
        Hide
        Benjamin Reed added a comment -

        ignore that last comment, it was posted to the wrong issue!

        Show
        Benjamin Reed added a comment - ignore that last comment, it was posted to the wrong issue!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #738 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/738/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #738 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/738/ )

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development