ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-688

explain session expiration better in the docs & faq

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We are not clear enough (and the diagram we do have seems misleading) on when session expirations are generated. In particular the fact that you only get expirations when the client is connected to the cluster, not when disconnected.

      we need to detail:

      1) when do you get expiration
      2) what is the sequence of events that the watcher sees, from disco state, to getting the expiration (say the expiration happens when the client is disco, what do you see in the watcher while you are getting reconnected)
      3) we need to give some examples of how to test this. We should be explicit that "pulling the network cable" on the client will not show expiration since the cliient will not be reconnected.

      1. ZOOKEEPER-688.patch
        4 kB
        Patrick Hunt
      2. ZOOKEEPER-688.patch
        4 kB
        Mahadev konar

        Activity

        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #716 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/716/)
        . explain session expiration better in the docs & faq (phunt via mahadev)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #716 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/716/ ) . explain session expiration better in the docs & faq (phunt via mahadev)
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks pat!

        Show
        Mahadev konar added a comment - I just committed this. thanks pat!
        Hide
        Mahadev konar added a comment -

        +1 for the patch. Ill update the FAQ to match whats on the forrest docs.

        Show
        Mahadev konar added a comment - +1 for the patch. Ill update the FAQ to match whats on the forrest docs.
        Hide
        Mahadev konar added a comment -

        just updated the patch with minor changes on automatic reconnects by the client library.

        Show
        Mahadev konar added a comment - just updated the patch with minor changes on automatic reconnects by the client library.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12438030/ZOOKEEPER-688.patch
        against trunk revision 919280.

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438030/ZOOKEEPER-688.patch against trunk revision 919280. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        I added more detail on how session expiration works.

        Show
        Patrick Hunt added a comment - I added more detail on how session expiration works.

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development