ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-681

Minor doc issue re unset maxClientCnxns

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.2.2
    • Fix Version/s: 3.3.0
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Just a small issue, the doc says that "Setting this to 0 or omitting it entirely removes the limit on concurrent connections.", but we ran without this setting, and saw: WARN [NIOServerCxn.Factory:2181:NIOServerCnxn$Factory@226] - Too many connections from /10.76.251.190 - max is 10

      Bug in doc possibly?

        Activity

        Hide
        Patrick Hunt added a comment -

        assigning to 3.3.0, the docs are def wrong.

        Show
        Patrick Hunt added a comment - assigning to 3.3.0, the docs are def wrong.
        Hide
        Patrick Hunt added a comment -

        This patch fixes the doc bug. No changes to code/tests.

        Show
        Patrick Hunt added a comment - This patch fixes the doc bug. No changes to code/tests.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12437929/ZOOKEEPER-681.patch
        against trunk revision 919149.

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/126/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/126/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/126/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12437929/ZOOKEEPER-681.patch against trunk revision 919149. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/126/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/126/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/126/console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        +1 the patch looks good!

        Show
        Mahadev konar added a comment - +1 the patch looks good!
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks pat!

        Show
        Mahadev konar added a comment - I just committed this. thanks pat!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #715 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/715/)
        . Minor doc issue re unset maxClientCnxns (phunt via mahadev)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #715 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/715/ ) . Minor doc issue re unset maxClientCnxns (phunt via mahadev)

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Vegard B. Havdal
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development