Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-669

watchedevent tostring should clearly output the state/type/path

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Critical
        • Resolution: Fixed
        • Affects Version/s: 3.1.2, 3.2.2
        • Fix Version/s: 3.3.0
        • Component/s: None
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          the current tostring method is broken

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            phunt Patrick Hunt added a comment -

            this patch cleans up tostring and provides all available information

            no test change - exercising this method already covered in the test code

            Show
            phunt Patrick Hunt added a comment - this patch cleans up tostring and provides all available information no test change - exercising this method already covered in the test code
            Hide
            Permalink
            mahadev Mahadev konar added a comment -

            +1 the patch looks good! ill wait for hudson to +1 and then commit.....

            Show
            mahadev Mahadev konar added a comment - +1 the patch looks good! ill wait for hudson to +1 and then commit.....
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12435751/ZOOKEEPER-669.patch
            against trunk revision 912052.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no tests are needed for this patch.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed core unit tests.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/testReport/
            Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/console

            This message is automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435751/ZOOKEEPER-669.patch against trunk revision 912052. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/console This message is automatically generated.
            Hide
            Permalink
            mahadev Mahadev konar added a comment -

            I just committed this. thanks pat!

            Show
            mahadev Mahadev konar added a comment - I just committed this. thanks pat!
            Hide
            Permalink
            hudson Hudson added a comment -

            Integrated in ZooKeeper-trunk #705 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/705/)
            . watchedevent tostring should clearly output the state/type/path (phunt via mahadev)

            Show
            hudson Hudson added a comment - Integrated in ZooKeeper-trunk #705 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/705/ ) . watchedevent tostring should clearly output the state/type/path (phunt via mahadev)

              People

              • Assignee:
                phunt Patrick Hunt
                Reporter:
                phunt Patrick Hunt
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development