Patrick Hunt added a comment - 13/Feb/10 00:00 this patch cleans up tostring and provides all available information no test change - exercising this method already covered in the test code

Mahadev konar added a comment - 19/Feb/10 06:42 +1 the patch looks good! ill wait for hudson to +1 and then commit.....

Hadoop QA added a comment - 20/Feb/10 01:50 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435751/ZOOKEEPER-669.patch against trunk revision 912052. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/console This message is automatically generated.

Mahadev konar added a comment - 23/Feb/10 18:25 I just committed this. thanks pat!

Hudson added a comment - 24/Feb/10 11:03 Integrated in ZooKeeper-trunk #705 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/705/ ) . watchedevent tostring should clearly output the state/type/path (phunt via mahadev)