ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-648

Fix releaseaudit warning count to zero

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ant releaseaudit -Dforrest.home=<> -Djava5.home=<>
      200 unknown license should be updated with Apache License headers

      releaseaudit:
      [java]
      [java] *****************************************************
      [java] Summary
      [java] -------
      [java] Notes: 57
      [java] Binaries: 95
      [java] Archives: 16
      [java] Standards: 954
      [java]
      [java] Apache Licensed: 610
      [java] Generated Documents: 144
      [java]
      [java] JavaDocs are generated and so license header is optional
      [java] Generated files do not required license headers
      [java]
      [java] 200 Unknown Licenses
      [java]
      [java] *******************************

      1. ZOOKEEPER-648.patch
        48 kB
        Patrick Hunt
      2. ZOOKEEPER-648.patch
        48 kB
        Patrick Hunt

        Activity

        Hide
        Henry Robinson added a comment -

        I just committed this. Thanks Patrick!

        Show
        Henry Robinson added a comment - I just committed this. Thanks Patrick!
        Hide
        Henry Robinson added a comment -

        +1 looks good to me

        Show
        Henry Robinson added a comment - +1 looks good to me
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12431047/ZOOKEEPER-648.patch
        against trunk revision 901510.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/45/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/45/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/45/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431047/ZOOKEEPER-648.patch against trunk revision 901510. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/45/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/45/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/45/console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Good catch, I left that in there so I wouldn't forget to add the dependency back. The updated patch fixes the issue.

        Show
        Patrick Hunt added a comment - Good catch, I left that in there so I wouldn't forget to add the dependency back. The updated patch fixes the issue.
        Hide
        Henry Robinson added a comment -

        This looks good to me. My only question is here:

        + <!--<target name="releaseaudit" depends="package, rats-taskdef" description="Release Audit activities"> -->

        Does this line need to stay in, given that it's commented out?

        Show
        Henry Robinson added a comment - This looks good to me. My only question is here: + <!--<target name="releaseaudit" depends="package, rats-taskdef" description="Release Audit activities"> --> Does this line need to stay in, given that it's commented out?
        Hide
        Patrick Hunt added a comment -

        test failure was in testleadershutdown (a known issue) please review/commit this

        Show
        Patrick Hunt added a comment - test failure was in testleadershutdown (a known issue) please review/commit this
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12430970/ZOOKEEPER-648.patch
        against trunk revision 901496.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/43/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/43/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/43/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430970/ZOOKEEPER-648.patch against trunk revision 901496. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/43/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/43/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/43/console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        this patch updates build.xml with some exclusions (also picks up rat from maven repo, upgraded to 0.6)
        it also updates some source files with proper license headers

        Show
        Patrick Hunt added a comment - this patch updates build.xml with some exclusions (also picks up rat from maven repo, upgraded to 0.6) it also updates some source files with proper license headers
        Hide
        Giridharan Kesavan added a comment -

        there are about 200 files without Apache License(AL) header. This jira is filed to fix the releaseaudit warnings by adding Apache License headers or by excluding files to which AL headers cant be added.

        mapreduce-847 can be used an example.

        Show
        Giridharan Kesavan added a comment - there are about 200 files without Apache License(AL) header. This jira is filed to fix the releaseaudit warnings by adding Apache License headers or by excluding files to which AL headers cant be added. mapreduce-847 can be used an example.
        Hide
        Patrick Hunt added a comment -

        I'm not sure what this JIRA is requesting. In some cases the RAT tool outputs invalid results, how do you want us to handle this? What
        version of rat are you using, from incubator or previous. More detail would be helpful.

        Show
        Patrick Hunt added a comment - I'm not sure what this JIRA is requesting. In some cases the RAT tool outputs invalid results, how do you want us to handle this? What version of rat are you using, from incubator or previous. More detail would be helpful.

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Giridharan Kesavan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development