[ZOOKEEPER-645] Bug in WriteLock recipe implementation?

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.2.2
• Component/s: recipes

Environment

3.2.2 java 1.6.0_12

• Assignee: Mahadev Konar
• Reporter: Jaakko Laine
• Created: 15/Jan/10 05:19
• Updated: 03/Feb/22 08:50

Description

Not sure, but there seem to be two issues in the example WriteLock:

(1) ZNodeName is sorted according to session ID first, and then according to znode sequence number. This might cause starvation as lower session IDs always get priority. WriteLock is not thread-safe in the first place, so having session ID involved in compare operation does not seem to make sense.

(2) if findPrefixInChildren finds previous ID, it should add dir in front of the ID

Issue Links

• Blocked: ZOOKEEPER-3221 WriteLock in recipes may get wrong child name as lock id
• links to: GitHub Pull Request #413