ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-629

FLELostMessageTest assumes that the first zxid on a startup of quorum is -1.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FLELostMessageTest assumes that the first zxid exchange will be -1 zxid. WIth ZOOKEEPER-596 the zxid would be 0 and not -1. So the corresponding change needs to be made to this test.

      1. ZOOKEEPER-629.patch
        0.9 kB
        Flavio Junqueira

        Issue Links

          Activity

          Gavin made changes -
          Link This issue is depended upon by ZOOKEEPER-596 [ ZOOKEEPER-596 ]
          Gavin made changes -
          Link This issue blocks ZOOKEEPER-596 [ ZOOKEEPER-596 ]
          Patrick Hunt made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Mahadev konar made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Mahadev konar added a comment -

          This was committed as part of ZOOKEEPER-596. Thanks flavio!

          Show
          Mahadev konar added a comment - This was committed as part of ZOOKEEPER-596 . Thanks flavio!
          Hide
          Mahadev konar added a comment -

          the -1 is because this patch is dependent on ZOOKEEPER-596 to get in. I will include this patch with ZOOKEEPER-596.

          thanks flavio.

          Show
          Mahadev konar added a comment - the -1 is because this patch is dependent on ZOOKEEPER-596 to get in. I will include this patch with ZOOKEEPER-596 . thanks flavio.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12428164/ZOOKEEPER-629.patch
          against trunk revision 891034.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/90/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/90/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/90/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428164/ZOOKEEPER-629.patch against trunk revision 891034. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/90/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/90/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/90/console This message is automatically generated.
          Flavio Junqueira made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Flavio Paiva Junqueira [ fpj ]
          Flavio Junqueira made changes -
          Attachment ZOOKEEPER-629.patch [ 12428164 ]
          Hide
          Flavio Junqueira added a comment -

          This patches fixes this issue.

          Show
          Flavio Junqueira added a comment - This patches fixes this issue.
          Flavio Junqueira made changes -
          Field Original Value New Value
          Link This issue blocks ZOOKEEPER-596 [ ZOOKEEPER-596 ]
          Mahadev konar created issue -

            People

            • Assignee:
              Flavio Junqueira
              Reporter:
              Mahadev konar
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development