ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-610

cleanup final fields, esp those used for locking

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: java client, server
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are a number of places where we have non-final fields that could (should) be declared as final.

        Activity

        Patrick Hunt created issue -
        Patrick Hunt made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-610.patch [ 12426874 ]
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Henry Robinson added a comment -

        Cancelling the patch in order to kick hudson.

        Show
        Henry Robinson added a comment - Cancelling the patch in order to kick hudson.
        Henry Robinson made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Henry Robinson added a comment -

        Resubmitting to push through hudsonqabot.

        Show
        Henry Robinson added a comment - Resubmitting to push through hudsonqabot.
        Henry Robinson made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12426874/ZOOKEEPER-610.patch
        against trunk revision 888216.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426874/ZOOKEEPER-610.patch against trunk revision 888216. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/console This message is automatically generated.
        Hide
        Henry Robinson added a comment -

        +1 from me, tests don't need to be included as there are no functional changes (compiler would pick up any problems). We are a bit inconsistent about when we initialise inline in the class, and when we initialise in the constructor, but that's not for this patch to fix.

        Will (attempt to) commit shortly.

        Show
        Henry Robinson added a comment - +1 from me, tests don't need to be included as there are no functional changes (compiler would pick up any problems). We are a bit inconsistent about when we initialise inline in the class, and when we initialise in the constructor, but that's not for this patch to fix. Will (attempt to) commit shortly.
        Hide
        Henry Robinson added a comment -

        I just committed this (svn revision 889843). Thanks Patrick!

        Show
        Henry Robinson added a comment - I just committed this (svn revision 889843). Thanks Patrick!
        Henry Robinson made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        7d 12h 6m 1 Henry Robinson 11/Dec/09 18:59
        Open Open Patch Available Patch Available
        2m 17s 2 Henry Robinson 11/Dec/09 19:00
        Patch Available Patch Available Resolved Resolved
        3h 57m 1 Henry Robinson 11/Dec/09 22:57
        Resolved Resolved Closed Closed
        104d 18h 28m 1 Patrick Hunt 26/Mar/10 17:25

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development