ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-588

remove unnecessary/annoying log of tostring error in Request.toString()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: server
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Why are we logging this? It's unnecessary and just annoying afaict. We should remove it entirely.

      2009-11-18 05:37:29,312 WARN org.apache.zookeeper.server.Request: Ignoring exception during toString
      java.nio.BufferUnderflowException
      at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:127)
      at java.nio.ByteBuffer.get(ByteBuffer.java:675)
      at org.apache.zookeeper.server.Request.toString(Request.java:199)
      at java.lang.String.valueOf(String.java:2827)
      at java.lang.StringBuilder.append(StringBuilder.java:115)
      at org.apache.zookeeper.server.quorum.CommitProcessor.processRequest(CommitProcessor.java:167)
      at org.apache.zookeeper.server.quorum.FollowerRequestProcessor.run(FollowerRequestProcessor.java:68)

        Activity

        Patrick Hunt created issue -
        Hide
        Patrick Hunt added a comment -

        fixed the tostring and also addressed a problem in the caller

        1) caller now tries to log the path if it knows it (since we may not be able to figure out in req tostring as that's sorta a hack

        2) added a few more exceptions to attempts to print reqpath in tostring

        3) added more sanity checks before attempting to determine path

        4) removed the annoying log message that caused this issue in the first place.

        Show
        Patrick Hunt added a comment - fixed the tostring and also addressed a problem in the caller 1) caller now tries to log the path if it knows it (since we may not be able to figure out in req tostring as that's sorta a hack 2) added a few more exceptions to attempts to print reqpath in tostring 3) added more sanity checks before attempting to determine path 4) removed the annoying log message that caused this issue in the first place.
        Patrick Hunt made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-588.patch [ 12425852 ]
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Patrick Hunt [ phunt ]
        Hide
        Benjamin Reed added a comment -

        +1 good job. my only small quibble is the coding style violation:

        )
        {

        rather than:

        ) {

        Show
        Benjamin Reed added a comment - +1 good job. my only small quibble is the coding style violation: ) { rather than: ) {
        Benjamin Reed made changes -
        Hadoop Flags [Reviewed]
        Hide
        Patrick Hunt added a comment -

        I always do that for multi-line conditional, I think it makes it easier to find the block bounds....

        Show
        Patrick Hunt added a comment - I always do that for multi-line conditional, I think it makes it easier to find the block bounds....
        Hide
        Benjamin Reed added a comment -

        Committed revision 889797.

        Show
        Benjamin Reed added a comment - Committed revision 889797.
        Benjamin Reed made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #625 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/625/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #625 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/625/ )
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Patrick Hunt made changes -
        Labels logging

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development