ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-551

unnecessary SetWatches message on new session

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: c client, java client
    • Labels:
      None

      Description

      The java client is sending a SetWatches message even on a new session (always empty). Additionally SetWatches is called
      even in the case of re-establishing session, however no watches are set. The code should check for watches before
      sending this (ie don't send empty setwatches). I see this on java, investigate c as well.

        Activity

        Hide
        Patrick Hunt added a comment -

        This patch changes the c/java code to not send setwatches message if there are no pending watches.

        I don't see how to neg test this - we are already verifying the positive cases so failure for hadoopqa should be expected but I think that's ok.

        Show
        Patrick Hunt added a comment - This patch changes the c/java code to not send setwatches message if there are no pending watches. I don't see how to neg test this - we are already verifying the positive cases so failure for hadoopqa should be expected but I think that's ok.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12424236/ZOOKEEPER-551.patch
        against trunk revision 833559.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424236/ZOOKEEPER-551.patch against trunk revision 833559. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        +1. I just committed this one, Pat. Thanks!

        Show
        Flavio Junqueira added a comment - +1. I just committed this one, Pat. Thanks!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #528 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/528/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #528 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/528/ )
        Hide
        Flavio Junqueira added a comment -

        Committed revision 833932

        Show
        Flavio Junqueira added a comment - Committed revision 833932

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development