[ZOOKEEPER-530] Memory corruption: Zookeeper c client IPv6 implementation does not honor struct sockaddr_in6 size

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.0, 3.2.1
• Fix Version/s: 3.3.0
• Component/s: c client
• Hadoop Flags: Reviewed
• Release Note: get the c client working with IPV6.
• Tags: ipv6
• Assignee: Isabel Drost-Fromm
• Reporter: Isabel Drost-Fromm
• Created: 21/Sep/09 09:17
• Updated: 26/Mar/10 17:25
• Resolved: 21/Oct/09 21:01

Description

I tried to run zookeeper c-client on a machine with IPv6 enabled. When connecting to the IPv6 address a connect(...) gave a "Address family not supported by protocol" error. The reason was, that a few lines earlier, the socket was opened with PF_INET instead of PF_INET6. Changing that the following way:

           if (zh->addrs[zh->connect_index].sa_family == AF_INET) {
            	zh->fd = socket(PF_INET, SOCK_STREAM, 0);
            } else {
            	zh->fd = socket(PF_INET6, SOCK_STREAM, 0);
            }

turned the error message into "Invalid argument".

When printing out sizeof(struct sockaddr), sizeof(struct sockaddr_in) and sizeof(struct sockaddr_in6) I got sockaddr: 16, sockaddr_in: 16 and sockaddr_in6: 28.

So in the code calling

           connect(zh->fd, &zh->addrs[zh->connect_index], sizeof(struct sockaddr_in));

the parameter address_len is too small.

Same applies to how IPv6 addresses are handled in the function getaddrs(zhandle_t *zh).

(Big Thanks+kiss to Thilo Fromm for helping me debug this.)