Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-518

DEBUG message for outstanding proposals in leader should be moved to trace.

    XMLWordPrintableJSON

Details

    • Test
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.0.0
    • 3.2.1, 3.3.0
    • tests
    • Non specific

    • Reviewed
    • The released of this module should be done only in apache org as this module is move to the debug to trace since it will cause really high latenciesinin response times from zookeeper services in case folks want to use DEBUGlogging for servers.

    Description

      this is the code in Leader.java

       if (LOG.isDebugEnabled()) {
                  LOG.debug("Ack zxid: 0x" + Long.toHexString(zxid));
                  for (Proposal p : outstandingProposals.values()) {
                      long packetZxid = p.packet.getZxid();
                      LOG.debug("outstanding proposal: 0x"
                              + Long.toHexString(packetZxid));
                  }
                  LOG.debug("outstanding proposals all");
              }
      
      

      We should move this debug to trace since it will cause really high latencies in response times from zookeeper servers in case folks want to use DEBUG logging for servers.

      Attachments

        1. ZOOKEEPER-518.patch
          1 kB
          Patrick D. Hunt

        Activity

          People

            phunt Patrick D. Hunt
            mahadev Mahadev Konar
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: