ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-518

DEBUG message for outstanding proposals in leader should be moved to trace.

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.0
    • Fix Version/s: 3.2.1, 3.3.0
    • Component/s: tests
    • Labels:
    • Environment:

      Non specific

    • Hadoop Flags:
      Reviewed
    • Release Note:
      The released of this module should be done only in apache org as this module is move to the debug to trace since it will cause really high latenciesinin response times from zookeeper services in case folks want to use DEBUGlogging for servers.

      Description

      this is the code in Leader.java

       if (LOG.isDebugEnabled()) {
                  LOG.debug("Ack zxid: 0x" + Long.toHexString(zxid));
                  for (Proposal p : outstandingProposals.values()) {
                      long packetZxid = p.packet.getZxid();
                      LOG.debug("outstanding proposal: 0x"
                              + Long.toHexString(packetZxid));
                  }
                  LOG.debug("outstanding proposals all");
              }
      
      

      We should move this debug to trace since it will cause really high latencies in response times from zookeeper servers in case folks want to use DEBUG logging for servers.

        Activity

        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #437 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/437/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #437 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/437/ )
        Hide
        Patrick Hunt added a comment -

        committed to trunk/3.2 branch.

        Show
        Patrick Hunt added a comment - committed to trunk/3.2 branch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12417755/ZOOKEEPER-518.patch
        against trunk revision 807484.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/191/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/191/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/191/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12417755/ZOOKEEPER-518.patch against trunk revision 807484. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/191/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/191/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/191/console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        +1 the patch looks good...

        Show
        Mahadev konar added a comment - +1 the patch looks good...
        Hide
        Patrick Hunt added a comment -

        this patch changes from debug to trace, that is all. I expect the qabot to fail (no test changed)

        Show
        Patrick Hunt added a comment - this patch changes from debug to trace, that is all. I expect the qabot to fail (no test changed)

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Mahadev konar
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development