ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-517

NIO factory fails to close connections when the number of file handles run out.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Duplicate
    • Affects Version/s: 3.4.3, 3.5.0
    • Fix Version/s: None
    • Component/s: server
    • Labels:
      None
    • Release Note:
      Fix NIO accept loop error handling

      Description

      The code in NIO factory is such that if we fail to accept a connection due to some reasons (too many file handles maybe one of them) we do not close the connections that are in CLOSE_WAIT. We need to call an explicit close on these sockets and then close them. One of the solutions might be to move doIO before accpet so that we can still close connection even if we cannot accept connections.

        Issue Links

          Activity

          Mahadev konar created issue -
          Patrick Hunt made changes -
          Field Original Value New Value
          Priority Major [ 3 ] Critical [ 2 ]
          Mahadev konar made changes -
          Fix Version/s 3.4.0 [ 12314469 ]
          Fix Version/s 3.3.0 [ 12313976 ]
          Patrick Hunt made changes -
          Fix Version/s 3.3.2 [ 12315108 ]
          Component/s server [ 12312382 ]
          Patrick Hunt made changes -
          Link This issue relates to ZOOKEEPER-801 [ ZOOKEEPER-801 ]
          Mahadev konar made changes -
          Assignee Benjamin Reed [ breed ]
          Mahadev konar made changes -
          Fix Version/s 3.3.3 [ 12315482 ]
          Fix Version/s 3.3.2 [ 12315108 ]
          Benjamin Reed made changes -
          Fix Version/s 3.3.3 [ 12315482 ]
          Mahadev konar made changes -
          Fix Version/s 3.5.0 [ 12316644 ]
          Fix Version/s 3.4.0 [ 12314469 ]
          Jay Shrauner made changes -
          Attachment ZOOKEEPER-517.patch [ 12522030 ]
          Jay Shrauner made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Release Note Fix NIO accept loop error handling
          Affects Version/s 3.4.3 [ 12319288 ]
          Affects Version/s 3.5.0 [ 12316644 ]
          Assignee Benjamin Reed [ breed ] Jay Shrauner [ shrauner ]
          Patrick Hunt made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 3.5.0 [ 12316644 ]
          Resolution Duplicate [ 3 ]

            People

            • Assignee:
              Jay Shrauner
              Reporter:
              Mahadev konar
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development