ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-511

bad error handling in FollowerHandler.sendPackets

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.3.0
    • Component/s: quorum, server
    • Labels:
      None

      Description

      in FollowerHandler if sendPackets gets an ioexception on writeRecord the send thread will exit, however the
      socket isn't necessarily closed.

      2009-08-19 15:28:46,869 - WARN [Sender-/127.0.0.1:58179:FollowerHandler@131] - Unexpected exception
      at org.apache.zookeeper.server.quorum.FollowerHandler.sendPackets(FollowerHandler.java:128)
      at org.apache.zookeeper.server.quorum.FollowerHandler.access$0(FollowerHandler.java:107)
      at org.apache.zookeeper.server.quorum.FollowerHandler$1.run(FollowerHandler.java:325)

      This results in the follower taking a very long time to recover and rejoin the quorum.

        Activity

        Hide
        Mahadev konar added a comment -

        this patch fixes the issue by closing the socket on a write error on the sendthread which will cause immediate notification of tcp socket error on the learner/observer side.

        Show
        Mahadev konar added a comment - this patch fixes the issue by closing the socket on a write error on the sendthread which will cause immediate notification of tcp socket error on the learner/observer side.
        Hide
        Mahadev konar added a comment -

        moving it to 3.3.

        Show
        Mahadev konar added a comment - moving it to 3.3.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12438061/ZOOKEEPER-511.patch
        against trunk revision 919640.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/130/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/130/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/130/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438061/ZOOKEEPER-511.patch against trunk revision 919640. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/130/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/130/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/130/console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        +1, thanks mahadev! Committed revision 921853.

        Show
        Flavio Junqueira added a comment - +1, thanks mahadev! Committed revision 921853.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #733 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/733/)
        . bad error handling in FollowerHandle.sendPackets (mahadev via flavio)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #733 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/733/ ) . bad error handling in FollowerHandle.sendPackets (mahadev via flavio)

          People

          • Assignee:
            Mahadev konar
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development