[ZOOKEEPER-4858] Remove the lock contention between snapshotting and the sync operation

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.9.0, 3.9.1, 3.9.2
• Component/s: server
• Labels: pull-request-available
• Assignee: Li Wang
• Reporter: Li Wang
• Created: 07/Sep/24 01:49
• Updated: 21/Oct/24 17:08

Description

Remove the synchronized keyword from Zookeeper.takeSnapshot() and ZookeeperServer.restoreFromSnapshot() API, as it causes lock contention on the ZookeeperServer object with the sync operation.

In ZookeeperServer.java, we have the following

 public synchronized File takeSnapshot(boolean syncSnap, boolean isSevere, boolean fastForwardFromEdits) throws IOException {
....
}

In ObserverZookeeperServer.java and FollowerZookeeperServer.java, we have the following

public synchronized void sync() {
     ...
    }

Issue Links

• links to: GitHub Pull Request #2185