[ZOOKEEPER-4791] Improve logging when the connection to a remote server is closed

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.9.1
• Fix Version/s: 3.10.0
• Component/s: server
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Sönke Liebau
• Created: 24/Jan/24 13:32
• Updated: 30/Jan/24 18:12
• Resolved: 30/Jan/24 18:10

Description

When a server closes the connection to a remote server, the logging around why the connection is being closed could be improved a bit.

https://github.com/apache/zookeeper/blob/1cc1eb6a2be7323a5c326652d59a070473bb8779/zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java#L524

ZooKeeperServer zks = this.zkServer;
if (zks == null || !zks.isRunning()) {
                            LOG.info("Closing connection to {} because the server is not ready",
                                    getRemoteSocketAddress());
                            close(DisconnectReason.IO_EXCEPTION);
                            return;
                        }

It would be helpful to log what zkServer is, because it can have multiple states that would trigger this shutdown.

Issue Links

• links to: GitHub Pull Request #2114